refactor: comprehensive codebase improvements for v2.8.0 - #12
Merged
Conversation
7a6163
commented
Mar 16, 2026
7a6163
commented
Owner
- Extract CheckOptions struct with clap::Args to eliminate parameter explosion
- Split cmd_check (310 lines) into 5 focused functions
- Split scanner.rs (1148 lines) into scanner/{mod,report,network}.rs
- Create shared lockfile/platform.rs to unify duplicated platform parsing
- Encapsulate parser state into SourceState struct with methods
- Migrate deprecated serde_yaml to serde_yml
- Fix Database::open().unwrap() panic with proper error propagation
- Extract check_staleness/build_ignore_comments to src/check.rs for testability
- Replace .ok() with io::Result<()> in format output (text.rs, json.rs)
- Handle broken pipe gracefully in CLI output
- Add tempfile crate for reliable test cleanup
- Add Clone derive to FixSuggestion
- Add 13 new unit tests (307 → 320)
- Extract CheckOptions struct with clap::Args to eliminate parameter explosion
- Split cmd_check (310 lines) into 5 focused functions
- Split scanner.rs (1148 lines) into scanner/{mod,report,network}.rs
- Create shared lockfile/platform.rs to unify duplicated platform parsing
- Encapsulate parser state into SourceState struct with methods
- Migrate deprecated serde_yaml to serde_yml
- Fix Database::open().unwrap() panic with proper error propagation
- Extract check_staleness/build_ignore_comments to src/check.rs for testability
- Replace .ok() with io::Result<()> in format output (text.rs, json.rs)
- Handle broken pipe gracefully in CLI output
- Add tempfile crate for reliable test cleanup
- Add Clone derive to FixSuggestion
- Add 13 new unit tests (307 → 320)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.