Skip to content

BJD converters use local microservice only.#612

Merged
dbenn merged 1 commit into
masterfrom
609-bjd-tdb-no-astroutils
Jun 8, 2026
Merged

BJD converters use local microservice only.#612
dbenn merged 1 commit into
masterfrom
609-bjd-tdb-no-astroutils

BJD converters use local microservice only.

323f6fd
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
GitHub Actions / SpotBugs completed Jun 7, 2026 in 0s

SpotBugs Source Code Analyzer report

622 violation(s) found

Annotations

Check warning on line 106 in src/org/aavso/tools/vstar/auth/AAVSOPostUserPassXMLAuthenticationSource.java

See this annotation in the file changed.

@github-actions github-actions / SpotBugs

DM_DEFAULT_ENCODING

Found reliance on default encoding in org.aavso.tools.vstar.auth.AAVSOPostUserPassXMLAuthenticationSource.authenticate(String, String): String.getBytes()
Raw output
Found a call to a method which will perform a byte to String (or String to byte) conversion, and will assume that the default platform encoding is suitable. This will cause the application behavior to vary between platforms. Use an alternative API and specify a charset name or Charset object explicitly.

Check warning on line 81 in src/org/aavso/tools/vstar/auth/Auth0JSONAutheticationSource.java

See this annotation in the file changed.

@github-actions github-actions / SpotBugs

DM_DEFAULT_ENCODING

Found reliance on default encoding in org.aavso.tools.vstar.auth.Auth0JSONAutheticationSource.authenticate(String, String): new java.io.InputStreamReader(InputStream)
Raw output
Found a call to a method which will perform a byte to String (or String to byte) conversion, and will assume that the default platform encoding is suitable. This will cause the application behavior to vary between platforms. Use an alternative API and specify a charset name or Charset object explicitly.

Check warning on line 62 in src/org/aavso/tools/vstar/data/CommentCodes.java

See this annotation in the file changed.

@github-actions github-actions / SpotBugs

DM_STRING_VOID_CTOR

new org.aavso.tools.vstar.data.CommentCodes(String) invokes inefficient new String() constructor
Raw output
Creating a new java.lang.String object using the no-argument constructor wastes memory because the object so created will be functionally indistinguishable from the empty string constant "".  Java guarantees that identical string constants will be represented by the same String object.  Therefore, you should just use the empty string constant directly.

Check warning on line 71 in src/org/aavso/tools/vstar/data/CommentCodes.java

See this annotation in the file changed.

@github-actions github-actions / SpotBugs

EI_EXPOSE_REP

org.aavso.tools.vstar.data.CommentCodes.getCommentcodes() may expose internal representation by returning CommentCodes.commentcodes
Raw output
Returning a reference to a mutable object value stored in one of the object's fields exposes the internal representation of the object.  If instances are accessed by untrusted code, and unchecked changes to the mutable object would compromise security or other important properties, you will need to do something different. Returning a new copy of the object is better approach in many situations.

Check warning on line 31 in src/org/aavso/tools/vstar/data/Property.java

See this annotation in the file changed.

@github-actions github-actions / SpotBugs

NM_CLASS_NAMING_CONVENTION

The class name org.aavso.tools.vstar.data.Property$propType doesn't start with an upper case letter
Raw output
Class names should be nouns, in mixed case with the first letter of each internal word capitalized. Try to keep your class names simple and descriptive. Use whole words-avoid acronyms and abbreviations (unless the abbreviation is much more widely used than the long form, such as URL or HTML).

Check warning on line 219 in src/org/aavso/tools/vstar/data/SeriesType.java

See this annotation in the file changed.

@github-actions github-actions / SpotBugs

MS_EXPOSE_REP

Public static org.aavso.tools.vstar.data.SeriesType.getSeriesColorChangeNotifier() may expose internal representation by returning SeriesType.seriesColorChangeNotifier
Raw output
A public static method returns a reference to a mutable object or an array that is part of the static state of the class. Any code that calls this method can freely modify the underlying array. One fix is to return a copy of the array.

Check warning on line 226 in src/org/aavso/tools/vstar/data/SeriesType.java

See this annotation in the file changed.

@github-actions github-actions / SpotBugs

MS_EXPOSE_REP

Public static org.aavso.tools.vstar.data.SeriesType.getSeriesSizeChangeNotifier() may expose internal representation by returning SeriesType.seriesSizeChangeNotifier
Raw output
A public static method returns a reference to a mutable object or an array that is part of the static state of the class. Any code that calls this method can freely modify the underlying array. One fix is to return a copy of the array.

Check warning on line 727 in src/org/aavso/tools/vstar/data/SeriesType.java

See this annotation in the file changed.

@github-actions github-actions / SpotBugs

MS_EXPOSE_REP

Public static org.aavso.tools.vstar.data.SeriesType.values() may expose internal representation by returning SeriesType.values
Raw output
A public static method returns a reference to a mutable object or an array that is part of the static state of the class. Any code that calls this method can freely modify the underlying array. One fix is to return a copy of the array.

Check warning on line 594 in src/org/aavso/tools/vstar/data/SeriesType.java

See this annotation in the file changed.

@github-actions github-actions / SpotBugs

WMI_WRONG_MAP_ITERATOR

org.aavso.tools.vstar.data.SeriesType.updateSeriesColorMap(Map) makes inefficient use of keySet iterator instead of entrySet iterator
Raw output
This method accesses the value of a Map entry, using a key that was retrieved from a keySet iterator. It is more efficient to use an iterator on the entrySet of the map, to avoid the Map.get(key) lookup.

Check warning on line 621 in src/org/aavso/tools/vstar/data/SeriesType.java

See this annotation in the file changed.

@github-actions github-actions / SpotBugs

WMI_WRONG_MAP_ITERATOR

org.aavso.tools.vstar.data.SeriesType.updateSeriesSizeMap(Map) makes inefficient use of keySet iterator instead of entrySet iterator
Raw output
This method accesses the value of a Map entry, using a key that was retrieved from a keySet iterator. It is more efficient to use an iterator on the entrySet of the map, to avoid the Map.get(key) lookup.

Check warning on line 344 in src/org/aavso/tools/vstar/data/ValidObservation.java

See this annotation in the file changed.

@github-actions github-actions / SpotBugs

EI_EXPOSE_REP

org.aavso.tools.vstar.data.ValidObservation.getDetails() may expose internal representation by returning ValidObservation.details
Raw output
Returning a reference to a mutable object value stored in one of the object's fields exposes the internal representation of the object.  If instances are accessed by untrusted code, and unchecked changes to the mutable object would compromise security or other important properties, you will need to do something different. Returning a new copy of the object is better approach in many situations.

Check warning on line 538 in src/org/aavso/tools/vstar/data/ValidObservation.java

See this annotation in the file changed.

@github-actions github-actions / SpotBugs

EI_EXPOSE_REP

org.aavso.tools.vstar.data.ValidObservation.getMagnitude() may expose internal representation by returning ValidObservation.magnitude
Raw output
Returning a reference to a mutable object value stored in one of the object's fields exposes the internal representation of the object.  If instances are accessed by untrusted code, and unchecked changes to the mutable object would compromise security or other important properties, you will need to do something different. Returning a new copy of the object is better approach in many situations.

Check warning on line 546 in src/org/aavso/tools/vstar/data/ValidObservation.java

See this annotation in the file changed.

@github-actions github-actions / SpotBugs

EI_EXPOSE_REP2

org.aavso.tools.vstar.data.ValidObservation.setMagnitude(Magnitude) may expose internal representation by storing an externally mutable object into ValidObservation.magnitude
Raw output
This code stores a reference to an externally mutable object into the internal representation of the object.  If instances are accessed by untrusted code, and unchecked changes to the mutable object would compromise security or other important properties, you will need to do something different. Storing a copy of the object is better approach in many situations.

Check warning on line 351 in src/org/aavso/tools/vstar/data/ValidObservation.java

See this annotation in the file changed.

@github-actions github-actions / SpotBugs

MS_EXPOSE_REP

Public static org.aavso.tools.vstar.data.ValidObservation.getDetailTitles() may expose internal representation by returning ValidObservation.detailTitles
Raw output
A public static method returns a reference to a mutable object or an array that is part of the static state of the class. Any code that calls this method can freely modify the underlying array. One fix is to return a copy of the array.

Check warning on line 358 in src/org/aavso/tools/vstar/data/ValidObservation.java

See this annotation in the file changed.

@github-actions github-actions / SpotBugs

MS_EXPOSE_REP

Public static org.aavso.tools.vstar.data.ValidObservation.getDetailTypes() may expose internal representation by returning ValidObservation.detailTypes
Raw output
A public static method returns a reference to a mutable object or an array that is part of the static state of the class. Any code that calls this method can freely modify the underlying array. One fix is to return a copy of the array.

Check warning on line 517 in src/org/aavso/tools/vstar/data/ValidObservation.java

See this annotation in the file changed.

@github-actions github-actions / SpotBugs

MS_EXPOSE_REP

Public static org.aavso.tools.vstar.data.ValidObservation.getStandardDetailKeys() may expose internal representation by returning ValidObservation.standardDetailKeys
Raw output
A public static method returns a reference to a mutable object or an array that is part of the static state of the class. Any code that calls this method can freely modify the underlying array. One fix is to return a copy of the array.

Check warning on line 398 in src/org/aavso/tools/vstar/data/ValidObservation.java

See this annotation in the file changed.

@github-actions github-actions / SpotBugs

ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD

Write to static field org.aavso.tools.vstar.data.ValidObservation.detailIndex from instance method org.aavso.tools.vstar.data.ValidObservation.addDetail(String, Property, String)
Raw output
This instance method writes to a static field. This is tricky to get correct if multiple instances are being manipulated, and generally bad practice.

Check warning on line 1139 in src/org/aavso/tools/vstar/data/ValidObservation.java

See this annotation in the file changed.

@github-actions github-actions / SpotBugs

WMI_WRONG_MAP_ITERATOR

org.aavso.tools.vstar.data.ValidObservation.toString() makes inefficient use of keySet iterator instead of entrySet iterator
Raw output
This method accesses the value of a Map entry, using a key that was retrieved from a keySet iterator. It is more efficient to use an iterator on the entrySet of the map, to avoid the Map.get(key) lookup.

Check warning on line 62 in src/org/aavso/tools/vstar/data/filter/AbstractObservationFieldMatcher.java

See this annotation in the file changed.

@github-actions github-actions / SpotBugs

CT_CONSTRUCTOR_THROW

Exception thrown in class org.aavso.tools.vstar.data.filter.AbstractObservationFieldMatcher at new org.aavso.tools.vstar.data.filter.AbstractObservationFieldMatcher(Object, ObservationMatcherOp, ObservationMatcherOp[]) will leave the constructor. The object under construction remains partially initialized and may be vulnerable to Finalizer attacks.
Raw output
Classes that throw exceptions in their constructors are vulnerable to Finalizer attacks

A finalizer attack can be prevented, by declaring the class final, using an empty finalizer declared as final, or by a clever use of a private constructor.

See SEI CERT Rule OBJ-11 [https://wiki.sei.cmu.edu/confluence/display/java/OBJ11-J.+Be+wary+of+letting+constructors+throw+exceptions] for more information.

Check warning on line 73 in src/org/aavso/tools/vstar/data/filter/AbstractObservationFieldMatcher.java

See this annotation in the file changed.

@github-actions github-actions / SpotBugs

CT_CONSTRUCTOR_THROW

Exception thrown in class org.aavso.tools.vstar.data.filter.AbstractObservationFieldMatcher at new org.aavso.tools.vstar.data.filter.AbstractObservationFieldMatcher(ObservationMatcherOp[]) will leave the constructor. The object under construction remains partially initialized and may be vulnerable to Finalizer attacks.
Raw output
Classes that throw exceptions in their constructors are vulnerable to Finalizer attacks

A finalizer attack can be prevented, by declaring the class final, using an empty finalizer declared as final, or by a clever use of a private constructor.

See SEI CERT Rule OBJ-11 [https://wiki.sei.cmu.edu/confluence/display/java/OBJ11-J.+Be+wary+of+letting+constructors+throw+exceptions] for more information.

Check warning on line 80 in src/org/aavso/tools/vstar/data/filter/AbstractObservationFieldMatcher.java

See this annotation in the file changed.

@github-actions github-actions / SpotBugs

EI_EXPOSE_REP

org.aavso.tools.vstar.data.filter.AbstractObservationFieldMatcher.getMatcherOps() may expose internal representation by returning AbstractObservationFieldMatcher.ops
Raw output
Returning a reference to a mutable object value stored in one of the object's fields exposes the internal representation of the object.  If instances are accessed by untrusted code, and unchecked changes to the mutable object would compromise security or other important properties, you will need to do something different. Returning a new copy of the object is better approach in many situations.

Check warning on line 104 in src/org/aavso/tools/vstar/data/filter/AbstractObservationFieldMatcher.java

See this annotation in the file changed.

@github-actions github-actions / SpotBugs

EI_EXPOSE_REP

org.aavso.tools.vstar.data.filter.AbstractObservationFieldMatcher.getObservationSelectionMessage() may expose internal representation by returning AbstractObservationFieldMatcher.observationSelectionMessage
Raw output
Returning a reference to a mutable object value stored in one of the object's fields exposes the internal representation of the object.  If instances are accessed by untrusted code, and unchecked changes to the mutable object would compromise security or other important properties, you will need to do something different. Returning a new copy of the object is better approach in many situations.

Check warning on line 46 in src/org/aavso/tools/vstar/data/filter/AbstractObservationFieldMatcher.java

See this annotation in the file changed.

@github-actions github-actions / SpotBugs

EI_EXPOSE_REP2

new org.aavso.tools.vstar.data.filter.AbstractObservationFieldMatcher(Object, ObservationMatcherOp, ObservationMatcherOp[]) may expose internal representation by storing an externally mutable object into AbstractObservationFieldMatcher.ops
Raw output
This code stores a reference to an externally mutable object into the internal representation of the object.  If instances are accessed by untrusted code, and unchecked changes to the mutable object would compromise security or other important properties, you will need to do something different. Storing a copy of the object is better approach in many situations.

Check warning on line 97 in src/org/aavso/tools/vstar/data/filter/AbstractObservationFieldMatcher.java

See this annotation in the file changed.

@github-actions github-actions / SpotBugs

EI_EXPOSE_REP2

org.aavso.tools.vstar.data.filter.AbstractObservationFieldMatcher.setSelectedObservationMessage(ObservationSelectionMessage) may expose internal representation by storing an externally mutable object into AbstractObservationFieldMatcher.observationSelectionMessage
Raw output
This code stores a reference to an externally mutable object into the internal representation of the object.  If instances are accessed by untrusted code, and unchecked changes to the mutable object would compromise security or other important properties, you will need to do something different. Storing a copy of the object is better approach in many situations.

Check warning on line 50 in src/org/aavso/tools/vstar/data/filter/BooleanFieldMatcher.java

See this annotation in the file changed.

@github-actions github-actions / SpotBugs

SF_SWITCH_NO_DEFAULT

Switch statement found in org.aavso.tools.vstar.data.filter.BooleanFieldMatcher.matches(ValidObservation) where default case is missing
Raw output
This method contains a switch statement where default case is missing. Usually you need to provide a default case.

Because the analysis only looks at the generated bytecode, this warning can be incorrect triggered if the default case is at the end of the switch statement and the switch statement doesn't contain break statements for other cases.