Refactor and simplify how private/public keys are tweaked for taproot spends #170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… spends - We should not expose a Script.pay2tr() methods that sends to a raw untweaked key. It's confusing and users should never need it anyway. - SchnorrTweak.NoTweak was not needed, it is simpler to just use an optional tweak when signing with the private key
Users now have to explicitly create a KeyPath or ScriptPath tweak.
Member
Author
|
Snapshots are published to https://central.sonatype.com/repository/maven-snapshots |
This was referenced Dec 16, 2025
t-bast
reviewed
Dec 17, 2025
Users had to cast null to ByteVector32?/ScriptTree? which was ugly. Now they have to pass in either an explicit script/script root or use an explicit TaprootTweak.
t-bast
reviewed
Dec 17, 2025
Member
t-bast
left a comment
t-bast
left a comment
There was a problem hiding this comment.
LGTM, just waiting to figure out whether we keep the snapshot repository or not
We can always temporarly add the snapshot repo back in PRs that test upstream snasphot dependencies (secpc256k1-kmp) and remove it when we update to a released version.
t-bast
approved these changes
Dec 18, 2025
sstone
added a commit
to ACINQ/phoenix
that referenced
this pull request
Dec 31, 2025
Includes: - a fix for uncaught deserialization errors (see ACINQ/lightning-kmp#843) - a update to bitcoin-kmp with a change to taproot tweaks (see ACINQ/bitcoin-kmp#170)
dpad85
pushed a commit
to ACINQ/phoenix
that referenced
this pull request
Jan 5, 2026
Includes: - a fix for uncaught deserialization errors (see ACINQ/lightning-kmp#843) - a update to bitcoin-kmp with a change to taproot tweaks (see ACINQ/bitcoin-kmp#170)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #169, branch was renamed so I can publish snapshot artefacts for downstream libraries.
Note: this PR is currently using secp256k1-kmp 0.22.0-SNAPSHOT (see ACINQ/secp256k1-kmp#136) and will need to be updated once secp256k1-kmp 0.22.0 has been released.