Get ready for storing partial commit signatures #2896
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sstone
force-pushed
the
input-info-taproot
branch
from
aa0a099 to
cf583ea
Compare
sstone
force-pushed
the
store-partial-signatures
branch
from
46ef2b7 to
155b8dc
Compare
sstone
force-pushed
the
input-info-taproot
branch
from
cf583ea to
8e147fb
Compare
sstone
force-pushed
the
store-partial-signatures
branch
2 times, most recently
from
452c0e0 to
16e75b0
Compare
remyers
reviewed
Sep 18, 2024
Contributor
remyers
left a comment
remyers
left a comment
There was a problem hiding this comment.
Just one nit, but otherwise seems like straight forward changes.
eclair-core/src/main/scala/fr/acinq/eclair/wire/internal/channel/version4/ChannelCodecs4.scala
Outdated
Show resolved
Hide resolved
sstone
force-pushed
the
input-info-taproot
branch
from
145fba5 to
4163f0e
Compare
sstone
force-pushed
the
store-partial-signatures
branch
from
57310de to
0ac5a45
Compare
sstone
force-pushed
the
input-info-taproot
branch
from
4163f0e to
e15cb29
Compare
sstone
force-pushed
the
store-partial-signatures
branch
from
0ac5a45 to
af1d5c7
Compare
sstone
force-pushed
the
input-info-taproot
branch
from
e15cb29 to
f83f006
Compare
sstone
force-pushed
the
store-partial-signatures
branch
from
af1d5c7 to
5e9706a
Compare
sstone
force-pushed
the
input-info-taproot
branch
from
f83f006 to
bde8e07
Compare
sstone
force-pushed
the
store-partial-signatures
branch
from
5e9706a to
1926d8a
Compare
sstone
force-pushed
the
input-info-taproot
branch
from
bde8e07 to
a35921c
Compare
sstone
force-pushed
the
store-partial-signatures
branch
from
1926d8a to
f9fa5ba
Compare
sstone
force-pushed
the
input-info-taproot
branch
from
a35921c to
d560a8c
Compare
sstone
force-pushed
the
store-partial-signatures
branch
from
f9fa5ba to
ca706c7
Compare
sstone
force-pushed
the
input-info-taproot
branch
from
d560a8c to
154235d
Compare
sstone
force-pushed
the
store-partial-signatures
branch
from
ca706c7 to
65e74f6
Compare
sstone
force-pushed
the
store-partial-signatures
branch
from
65e74f6 to
fe63e30
Compare
sstone
force-pushed
the
input-info-taproot
branch
2 times, most recently
from
d100069 to
d2dfd07
Compare
We currently store our peer's signature for our remote commit tx, so we can publish it if needed. If we upgrade funding tx to use musig2 instead of multisig 2-of-2 we will need to store a partial signature instead.
sstone
force-pushed
the
store-partial-signatures
branch
from
fe63e30 to
a77aa5f
Compare
t-bast
reviewed
Jan 14, 2025
eclair-core/src/main/scala/fr/acinq/eclair/channel/Commitments.scala
Outdated
Show resolved
Hide resolved
eclair-core/src/main/scala/fr/acinq/eclair/channel/fund/InteractiveTxBuilder.scala
Outdated
Show resolved
Hide resolved
eclair-core/src/main/scala/fr/acinq/eclair/remote/LightningMessageSerializer.scala
Outdated
Show resolved
Hide resolved
eclair-core/src/main/scala/fr/acinq/eclair/wire/internal/channel/version4/ChannelCodecs4.scala
Outdated
Show resolved
Hide resolved
We create specific types for standard signature (64 bytes) and musig2 partial signatures + nonce.
We use a custom JSON serializer for remote signature which can only be full (64 bytes) signatures.
sstone
force-pushed
the
store-partial-signatures
branch
from
a9ef564 to
ad12f32
Compare
t-bast
reviewed
Jan 15, 2025
Member
t-bast
left a comment
t-bast
left a comment
There was a problem hiding this comment.
A few more changes and this should be ready to go!
eclair-core/src/main/scala/fr/acinq/eclair/channel/Commitments.scala
Outdated
Show resolved
Hide resolved
eclair-core/src/main/scala/fr/acinq/eclair/json/JsonSerializers.scala
Outdated
Show resolved
Hide resolved
eclair-core/src/main/scala/fr/acinq/eclair/wire/internal/channel/version3/ChannelCodecs3.scala
Show resolved
Hide resolved
t-bast
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another preparation PR for simple taproot channels that builds on top of #2895.
We currently store our peer's signature for our remote commit tx, so we can publish it if needed. If we upgrade funding tx to use musig2 instead of multisig 2-of-2 we will need to store a partial signature instead.