Add logs for balance estimate #2939
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The balance estimates are sometimes outside the range [0, 1] which should never happen. We add some logs to help debug it. We also stop calling `TimestampSecond.now()` multiple times during the computation and reuse the same value which may fix the issue.
t-bast
approved these changes
Nov 20, 2024
Member
t-bast
left a comment
t-bast
left a comment
There was a problem hiding this comment.
I don't see an obvious reason why we'd see values outside of [0;1], those logs will be helpful to troubleshoot, feel free to merge this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The balance estimates are sometimes outside the range [0, 1] which should never happen. We add some logs to help debug it. We also stop calling
TimestampSecond.now()multiple times during the computation and reuse the same value which may fix the issue.