Skip to content

Disable DepthAI nodes with mock_hardware flag#27

Merged
macmacal merged 8 commits intohumble-develfrom
feature/depthai_camera_fake_hardware
Feb 24, 2025
Merged

Disable DepthAI nodes with mock_hardware flag#27
macmacal merged 8 commits intohumble-develfrom
feature/depthai_camera_fake_hardware

Conversation

@macmacal
Copy link
Contributor

@macmacal macmacal commented Feb 12, 2025 •
edited
Loading

Description

From now the depthai_cameras_driver.launch.py launch file (in the aegis_control package) dosen't run DepthAI nodes when the mock_hardware is enabled.

In addition, this file has been enhanced with:

  • typings,
  • LaunchConfiguration extraction to one place,

Motivation and context

  • The logs spam in the console (about re-connecting to the camera) wasn't helping.

Related PRs

How has this been tested?

  • Manually, by running the whole project on genosis
    • with mock_hardware:=true
    • with mock_hardware:=false

Checklist

  • All TODOs in the code have been resolved or linked to a proper issue.
  • Code has been (auto)formatted.
  • Documentation (e.g., README, CHANGELOG, Wiki) has been updated.
  • All automated checks have passed.

Clickup task: 8697umbbq

@macmacal macmacal added the enhancement New feature or request label Feb 12, 2025
@macmacal macmacal changed the title Feature/depthai camera fake hardware Disable DepthAI nodes with mock_hardware flag Feb 12, 2025
@macmacal macmacal requested a review from sivral February 12, 2025 18:01
@macmacal macmacal mentioned this pull request Feb 12, 2025
Merged
4 tasks
sivral

This comment was marked as outdated.

Sign in to view

@sivral sivral self-requested a review February 18, 2025 11:41
sivral
sivral requested changes Feb 21, 2025
View reviewed changes
sivral

This comment was marked as outdated.

Sign in to view

sivral
sivral requested changes Feb 21, 2025
View reviewed changes
macmacal and others added 2 commits February 21, 2025 16:43
@macmacal @sivral
Apply suggestions from code review
30f5e2f 
Co-authored-by: Jakub <sivral@proton.me>
@macmacal
fmt
d566d90
@macmacal macmacal mentioned this pull request Feb 21, 2025
Open
@macmacal
Copy link
Contributor Author

macmacal commented Feb 21, 2025

I have found a problem with point cloud, which should be investigated more. See #29 .

sivral
sivral approved these changes Feb 24, 2025
View reviewed changes
Copy link
Contributor

@sivral sivral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@macmacal macmacal merged commit 811591b into humble-devel Feb 24, 2025
1 check passed
@macmacal macmacal deleted the feature/depthai_camera_fake_hardware branch February 24, 2025 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sivral sivral sivral approved these changes

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@macmacal @sivral