Fix typo ip_adress to socat_ip_address#15
Merged
sivral merged 5 commits intohumble-develfrom Aug 25, 2025
Merged
Conversation
macmacal
requested changes
Aug 25, 2025
macmacal
left a comment
macmacal
left a comment
There was a problem hiding this comment.
As we have talked: add socat_ prefixes to the ip_address and port arguments to omit the collisions in the namespace
macmacal
changed the title
ip_adress to ip_addressip_adress to socat_ip_address
4 tasks
slimasziom
approved these changes
Aug 25, 2025
4 tasks
slimasziom
added a commit
that referenced
this pull request
Aug 25, 2025
* Update CHANGELOG.md * FIX: change inertial macro name to avoid namespace collisions (#6) * FIX: change inertial macro name to avoid namespace collisions * CHG: docs * CHG: pre-commit * Update urdf/robotiq_hande_gripper.xacro Co-authored-by: Maciej Aleksandrowicz <mac.aleksandrowicz@gmail.com> * REV: cylinder_inertial filename --------- Co-authored-by: Maciej Aleksandrowicz <mac.aleksandrowicz@gmail.com> * CHG: changelog * CHG: package version bump * added citation file * bumped version * fixed default rotatation of hande * updated citation file * CHG: changelog * Make gripper mounting pose configurable * Format * Format * Format * Update changelog * Update changelog Co-authored-by: Maciej Aleksandrowicz <mac.aleksandrowicz@gmail.com> * added param frequency_hz * hande: changed `tty` to `tty_port` * added socat params * renamed virtual_tty to socat_tty * updated cmake version * fmt * updated changelog * updated changelog * Merge pull request #15 from AGH-CEAI/bugfix/fix_typo Fix typo * CHG: bump version * FIX: docs * CHG: bumb citation version --------- Co-authored-by: Maciej Aleksandrowicz <mac.aleksandrowicz@gmail.com> Co-authored-by: Jakub <sivral@proton.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a typo in a variable from
ip_adresstosocat_ip_addressandporttosocat_port.Motivation and context
The typo in the
socat_ip_addressvariable was fixed in PR #23 in the robotiq_hande_driver repository. Correcting this ensures consistency and avoids potential runtime errors when specifying the IP address for TCP connections.How has this been tested?
Manually, on the Geonosis PC.
Related PRs
Checklist
Clickup Task: 869a6nn34