Skip to content

Package refinement: Models update#3

Merged
macmacal merged 19 commits intohumble-develfrom
feature/minor_improvments
Mar 13, 2025
Merged

Package refinement: Models update#3
macmacal merged 19 commits intohumble-develfrom
feature/minor_improvments

Conversation

@macmacal
Copy link

@macmacal macmacal commented Mar 12, 2025

Description

This PR started as package of a minor Quality of Life improvements but resulted in a major changes: whole update of the Hand-E models, especially the the coupler was changed to the "IO coupler".

Motivation and context

  • Improve the overall quality of the package before the initial release of the robotiq_hande_driver.

Screenshots:

image
image

How has this been tested?

  • Manually, by launching preview in RViz.

Checklist

  • All TODOs in the code have been resolved or linked to a proper issue.
  • Code has been (auto)formatted.
  • Documentation (e.g., README, CHANGELOG, Wiki) has been updated.
  • All automated checks have passed.

Clickup task: 8696v4h8t

@macmacal macmacal added the enhancement New feature or request label Mar 12, 2025
Copy link

@slimasziom slimasziom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@macmacal macmacal changed the title Updated coupler model + minor improvements Package refinement: updated models Mar 12, 2025
@macmacal macmacal marked this pull request as draft March 12, 2025 18:41
@macmacal macmacal changed the title Package refinement: updated models Package refinement: Models update Mar 12, 2025
@macmacal macmacal marked this pull request as ready for review March 12, 2025 19:07
Copy link

@slimasziom slimasziom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One typo, the rest is fine.

slimasziom and others added 2 commits March 13, 2025 10:24
Co-authored-by: Krzysztof-Klimek <slimasziom@gmail.com>
@macmacal macmacal requested a review from sivral March 13, 2025 09:49
Copy link

@sivral sivral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@macmacal macmacal merged commit afbfc29 into humble-devel Mar 13, 2025
1 check passed
@macmacal macmacal deleted the feature/minor_improvments branch March 13, 2025 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants