Fix test_13 in relation to IS-07 senders #886
Conversation
| def get_valid_transports_with_transport_file(self, api_version): | ||
| """Identify the valid transport types which allow a transport file for a given version of IS-05""" | ||
| valid_transports = ["urn:x-nmos:transport:rtp", | ||
| "urn:x-nmos:transport:rtp.mcast", |
There was a problem hiding this comment.
This list is already out-dated with IPMX USB having a transport file ... I think the exclusion must come from the test suite using the IS-05 utilities or from the config file such that it can easily be updated.
There was a problem hiding this comment.
Hi @alabou,
That's the reason I added a separate method in the IS-05Utils or did you mean some other IS-05 utilities?
There was a problem hiding this comment.
My concern was that the get_valid_transports_with_transport_file method defined a static v1.1 view of the transports supporting an SDP transport file. But reconsidering that the IS-05 test suite is specific to v1.1 transports, I think your suggestion is ok as it is and that testing of new post v1.1 transports simply must not use the get_valid_transports and get_valid_transports_with_transport_file methods.
There was a problem hiding this comment.
Or at the point that we have IS-05 v1.2 that function is updated?
When the device under test also exposes IS-07 senders which do not require a transport file test_13 currently results in a
COULD NOT TESTwith the following message:This PR effectively just filters the MQTT and WebSocket transports from the list of target transports for this test by creating a separate
get_valid_transports_with_transport_filein the IS05Utils and using that.