Skip to content

Fix test_13 in relation to IS-07 senders #886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix test_13 in relation to IS-07 senders #886

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4db2818
Fix test_13 in relation to IS-07 senders/receivers
cristian-recoseanu Nov 28, 2025
63ff535
Fix lint issues
cristian-recoseanu Nov 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions nmostesting/IS05Utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,14 @@ def get_valid_transports(self, api_version):
valid_transports.append("urn:x-nmos:transport:mqtt")
return valid_transports

def get_valid_transports_with_transport_file(self, api_version):
"""Identify the valid transport types which allow a transport file for a given version of IS-05"""
valid_transports = ["urn:x-nmos:transport:rtp",
"urn:x-nmos:transport:rtp.mcast",
Copy link
Collaborator

@alabou alabou Nov 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This list is already out-dated with IPMX USB having a transport file ... I think the exclusion must come from the test suite using the IS-05 utilities or from the config file such that it can easily be updated.

Copy link
Contributor Author

@cristian-recoseanu cristian-recoseanu Dec 1, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @alabou,

That's the reason I added a separate method in the IS-05Utils or did you mean some other IS-05 utilities?

Copy link
Collaborator

@alabou alabou Dec 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My concern was that the get_valid_transports_with_transport_file method defined a static v1.1 view of the transports supporting an SDP transport file. But reconsidering that the IS-05 test suite is specific to v1.1 transports, I think your suggestion is ok as it is and that testing of new post v1.1 transports simply must not use the get_valid_transports and get_valid_transports_with_transport_file methods.

Copy link
Contributor

@garethsb garethsb Dec 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or at the point that we have IS-05 v1.2 that function is updated?

"urn:x-nmos:transport:rtp.ucast",
"urn:x-nmos:transport:dash"]
return valid_transports

def check_num_legs(self, url, res_type, uuid):
"""Checks the number of legs present on a given sender/receiver"""
min = 1
Expand Down
3 changes: 2 additions & 1 deletion nmostesting/suites/IS0502Test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -579,7 +579,8 @@ def test_13(self, test):
return test.FAIL(result)

try:
valid_transports = self.is05_utils.get_valid_transports(self.apis[CONN_API_KEY]["version"])
valid_transports = self.is05_utils.get_valid_transports_with_transport_file(
self.apis[CONN_API_KEY]["version"])

access_error = False

Expand Down