Skip to content

[#310] Publish bsk_rl wheels to PyPi#311

Merged
ReeceHumphreys merged 1 commit intodevelopfrom
feature/pypi-release
Sep 22, 2025
Merged

[#310] Publish bsk_rl wheels to PyPi#311
ReeceHumphreys merged 1 commit intodevelopfrom
feature/pypi-release

Conversation

@ReeceHumphreys
Copy link
Contributor

@ReeceHumphreys ReeceHumphreys commented Sep 22, 2025

Description

Closes #308

Adds a automated release workflow that triggers on PR closes just like Basilisk.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How should this pull request be reviewed?

  • By commit
  • All changes at once

How Has This Been Tested?

https://github.com/AVSLab/bsk_rl/actions/runs/17926533753

A test tag was used to trigger a release to the test pypi index. Can be installed with

pip install \
  --index-url https://test.pypi.org/simple/ \
  --extra-index-url https://pypi.org/simple/ \
  bsk_rl

Future Work

N/A

Checklist

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation and release notes
  • My changes generate no new warnings
  • [] I have added tests that prove my fix is effective or that my feature works

@ReeceHumphreys ReeceHumphreys marked this pull request as ready for review September 22, 2025 19:48
Copilot AI review requested due to automatic review settings September 22, 2025 19:48
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds an automated release workflow to publish bsk_rl wheels to PyPI, similar to the existing Basilisk workflow. The workflow triggers on PR closes and creates tagged releases that are automatically published to PyPI.

  • Enhances version bumper script to expose updated version to GitHub Actions
  • Modifies PR closed workflow to create git tags after version bumps
  • Adds new publish-wheels workflow that builds and publishes packages to PyPI on tag pushes

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
.github/workflows/version_bumper.sh Adds GitHub Actions output to expose updated version number
.github/workflows/pull_request_closed.yml Adds tag creation step using the bumped version
.github/workflows/publish-wheels.yml New workflow for building and publishing wheels to PyPI/TestPyPI

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Contributor

@Mark2000 Mark2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ReeceHumphreys ReeceHumphreys self-assigned this Sep 22, 2025
@ReeceHumphreys ReeceHumphreys added the enhancement New feature or request label Sep 22, 2025
@ReeceHumphreys ReeceHumphreys merged commit 7da091f into develop Sep 22, 2025
7 checks passed
@ReeceHumphreys ReeceHumphreys deleted the feature/pypi-release branch September 22, 2025 20:10
@github-project-automation github-project-automation bot moved this to ✅ Done in Basilisk Sep 22, 2025
Accommodus added a commit to Accommodus/bsk_rl that referenced this pull request Oct 4, 2025
Accommodus added a commit to Accommodus/bsk_rl that referenced this pull request Oct 4, 2025
Accommodus added a commit to Accommodus/bsk_rl that referenced this pull request Oct 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Use bsk wheel from PyPi

2 participants