Fix GLSL implementation of layer node#2368
Merged
jstone-lucasfilm merged 1 commit intoMay 5, 2025
Merged
Conversation
This changelist fixes a typo in the GLSL implementation of the `layer` node, where the throughput term was computed via addition rather than multiplication. For more straightforward validation, the `layer_bsdf.mtlx` example has been updated so that the throughput computation in `layer` influences its rendered result.
Member
Author
|
Here's a render of the layering example before the fix, where energy is unintentionally created between layers:
And here's a render of the layering example after the fix:
|
ld-kerley
approved these changes
May 5, 2025
ld-kerley
left a comment
ld-kerley
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me - thanks for catching my typo - sorry it slipped thru.
I'm glad we have a test case that exercises this correctly now.
jstone-lucasfilm
merged commit 308c7d0
into
AcademySoftwareFoundation:main
32 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changelist fixes a typo in the GLSL implementation of the
layernode, where the throughput term was computed via addition rather than multiplication.For more straightforward validation, the
layer_bsdf.mtlxexample has been updated so that the throughput computation inlayerinfluences its rendered result.