Skip to content

Fix GLSL implementation of layer node #2368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jstone-lucasfilm merged 1 commit into from
May 5, 2025
Merged

Fix GLSL implementation of layer node #2368

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion libraries/pbrlib/genglsl/mx_layer_bsdf.glsl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,5 @@
void mx_layer_bsdf(ClosureData closureData, BSDF top, BSDF base, out BSDF result)
{
result.response = top.response + base.response * top.throughput;
result.throughput = top.throughput + base.throughput;
result.throughput = top.throughput * base.throughput;
}
12 changes: 6 additions & 6 deletions resources/Materials/TestSuite/pbrlib/bsdf/layer_bsdf.mtlx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,16 +11,16 @@
<input name="tint" type="color3" value="1,0,0" />
</dielectric_bsdf>
<layer name="layer_bsdf_1" type="BSDF">
<input name="top" type="BSDF" nodename="sheen_brdf_1" />
<input name="base" type="BSDF" nodename="diffuse_brdf_1" />
<input name="top" type="BSDF" nodename="dielectric_brdf_2" />
<input name="base" type="BSDF" nodename="dielectric_brdf_1" />
</layer>
<layer name="layer_bsdf_2" type="BSDF">
<input name="top" type="BSDF" nodename="dielectric_brdf_1" />
<input name="base" type="BSDF" nodename="layer_bsdf_1" />
<input name="top" type="BSDF" nodename="layer_bsdf_1" />
<input name="base" type="BSDF" nodename="sheen_brdf_1" />
</layer>
<layer name="layer_bsdf_3" type="BSDF">
<input name="top" type="BSDF" nodename="dielectric_brdf_2" />
<input name="base" type="BSDF" nodename="layer_bsdf_2" />
<input name="top" type="BSDF" nodename="layer_bsdf_2" />
<input name="base" type="BSDF" nodename="diffuse_brdf_1" />
</layer>
<surface name="surface1" type="surfaceshader">
<input name="bsdf" type="BSDF" nodename="layer_bsdf_3" />
Expand Down