Image overhaul (WIP) #236
Draft
Image overhaul (WIP) #236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changelist merges v1.1 development from dev_1.1 to main, in preparation for marking the release of OpenPBR v1.1.
Adding here the finalized logo. This is almost identical to the one posted on Slack, except: - extremely small adjustment to the arrow head, to make it perfectly centered on and orthogonal to the stroke - SVG was optimized to remove redundant elements (e.g. gradients). Main logo is now only 10Kb. PNGs exported at 800dpi.
|
|
||
|    | ||
| <div class="shifted-caption"> | ||
| ![Figure [fuzz]: A checkerboard **`coat_weight`**, varying the **`coat_darkening`** over 0, 0.5, 1 (default).](dummy) |
Contributor
There was a problem hiding this comment.
I find this particular illustration difficult to understand. The wood looks glossy everywhere, which I interpret as coated everywhere. If the intent is to show a checker of coated vs non coated parts, I'd suggest using a rough base layer.
Implements the change described in AcademySoftwareFoundation#229.
…oftwareFoundation#238) Rather than eliminating the `specular_weight` > 1 case (as proposed in AcademySoftwareFoundation#228), we discussed keeping this but fixing up the metal logic to ensure the Fresnel remains bounded. This makes the corresponding change needed in the spec. (Note that now the `specular_weight` parameter consistently, for both metal and dielectric, has soft-range $[0,1]$ and full range $[0, \infty]$). It would be good to double check that the behaviour of the metal looks reasonable for high `specular_weight` values (presumably, similar to the dielectric where the Fresnel saturates).
AdrienHerubel
requested changes
Sep 30, 2025
Contributor
AdrienHerubel
left a comment
AdrienHerubel
left a comment
There was a problem hiding this comment.
Let's address the comment from @virtualzavie and get that change in for the fix release, we can add more updates in other PRs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating images to use the new shaderball, and adding some new images.
Also indenting the anisotropy diagram to make it less distracting.