Skip to content

Fix: Use RV's python version to build wheels #1009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 1, 2025
Merged

Fix: Use RV's python version to build wheels #1009

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4b61324
Fix: Use RV's python version to build wheels
rogernelson Dec 1, 2025
2448510
Unifying otio build params across OSes
rogernelson Dec 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions cmake/dependencies/python3.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,6 +266,8 @@ IF(RV_TARGET_WINDOWS)
# for pybind11 v2.13.6+ which has stricter Python library detection.
# Note: pybind11's FindPythonLibsNew.cmake uses PYTHON_LIBRARY (all caps),
# PYTHON_INCLUDE_DIR, and PYTHON_EXECUTABLE variables.
# --no-cache-dir: Don't use pip's wheel cache (prevents using wheels built for wrong Python version)
# --force-reinstall: Reinstall packages even if already installed (ensures fresh build)

IF(CMAKE_BUILD_TYPE MATCHES "^Debug$")
# For Debug builds, we need to tell OpenTimelineIO to build in debug mode
Expand All @@ -274,18 +276,26 @@ IF(RV_TARGET_WINDOWS)
${CMAKE_COMMAND} -E env
"OTIO_CXX_DEBUG_BUILD=1"
"CMAKE_ARGS=-DPYTHON_LIBRARY=${_python3_implib} -DPYTHON_INCLUDE_DIR=${_include_dir} -DPYTHON_EXECUTABLE=${_python3_executable}"
"${_python3_executable}" -m pip install --upgrade -r "${_requirements_output_file}"
"${_python3_executable}" -m pip install --upgrade --no-cache-dir --force-reinstall -r "${_requirements_output_file}"
)
ELSE()
SET(_requirements_install_command
${CMAKE_COMMAND} -E env
"CMAKE_ARGS=-DPYTHON_LIBRARY=${_python3_implib} -DPYTHON_INCLUDE_DIR=${_include_dir} -DPYTHON_EXECUTABLE=${_python3_executable}"
"${_python3_executable}" -m pip install --upgrade -r "${_requirements_output_file}"
"${_python3_executable}" -m pip install --upgrade --no-cache-dir --force-reinstall -r "${_requirements_output_file}"
)
ENDIF()
ELSE()
# On macOS and Linux, force pip to build OpenTimelineIO from source and avoid using
# cached wheels that may have been built for a different Python version.
# This ensures ABI compatibility with our custom-built Python.
# --no-cache-dir: Don't use pip's wheel cache (prevents using wheels built for wrong Python version)
# --force-reinstall: Reinstall packages even if already installed (ensures fresh build)
# CMAKE_ARGS: Tell OTIO's CMake build which Python to use (prevents it from finding system Python via pyenv/etc)
SET(_requirements_install_command
"${_python3_executable}" -m pip install --upgrade -r "${_requirements_output_file}"
${CMAKE_COMMAND} -E env
"CMAKE_ARGS=-DPYTHON_EXECUTABLE=${_python3_executable}"
"${_python3_executable}" -m pip install --upgrade --no-cache-dir --force-reinstall -r "${_requirements_output_file}"
)
ENDIF()

Expand Down
Loading