Add OfxImageEffectPropNoSpatialAwareness

[gregcotten]

Plugins should be able to opt-in to host's LUT generators (or other non-spatial renders), and hosts need a way of indicating to the plugin that the current render requires rendering without spatial awareness.

Resolve has already defined an extension OfxImageEffectPropNoSpatialAwareness, so I propose using that for both the plugin descriptor and the read-only render argument passed by the host.

Closes #127

[garyo]

LGTM! Once this is merged, please add a note in release-notes.md for it.

[gregcotten]

LGTM! Once this is merged, please add a note in release-notes.md for it.

Would it be better to add it in this PR instead?

[gregcotten]

@barretpj at your convenience, does this look OK to you?

[gregcotten]

OK, I'm all set. Just need to know if @garyo would like the change to release-notes.md added to this PR

[garyo]

If you don't mind rebasing this onto latest main, where I just started a 1.6 section of release-notes.md, then yes please, that would be great. Rebase and add to the relnotes.

[gregcotten]

If you don't mind rebasing this onto latest main, where I just started a 1.6 section of release-notes.md, then yes please, that would be great. Rebase and add to the relnotes.

done

[revisionfx]

I saw a comment about kOfxImageEffectPropRenderQualityDraft
What would be more useful to us is kOfxImageEffectPropRenderQualityThumbnails

Pierre

[gregcotten]

I saw a comment about kOfxImageEffectPropRenderQualityDraft What would be more useful to us is kOfxImageEffectPropRenderQualityThumbnails

Might want to make a new issue about that. This one is closed!

[barretpj]

I saw a comment about kOfxImageEffectPropRenderQualityDraft What would be more useful to us is kOfxImageEffectPropRenderQualityThumbnails

Might want to make a new issue about that. This one is closed!

Done - #193

[barretpj]

(It should really be NoTemporal as well...)

[revisionfx]

DO you mean multi-frame processing (get 3 frames from input) - Yes|OK - But what things like basic time offsets performed by plugin (even if only a single frame is requested)?.. Some hosts have a single thumbnail (a one time thing using first or current frame) while other populates on a timeline multiple frames.

[barretpj]

This is nothing to do with thumbnails. This is when we want to do a render which only changes the colour of pixels based on their input colour, so the host can analyse the overall render and approximate the changes with a LUT. If the plugin is considering other pixels, or pixels from images at other times, then the image analysis in the host will most likely fail.

[gregcotten]

I believe @barretpj is referring to a render with NoSpatialAwareness set to "true" should also mean it has "no temporal awareness"

[garyo]

This PR is already merged, and we're using the prop name from Resolve. And yes I agree w/ @barretpj . but I don't think we should change the prop name.

[gregcotten]

This is nothing to do with thumbnails. This is when we want to do a render which only changes the colour of pixels based on their input colour, so the host can analyse the overall render and approximate the changes with a LUT. If the plugin is considering other pixels, or pixels from images at other times, then the image analysis in the host will most likely fail.

Sensible. We can adjust the description accordingly.

[barretpj]

@revisionfx Plugins must only set NoSpatialAwareness="true" if they are able to operate in a change-current-frame-pixel-colour-only mode (either all the time, or when requested by the host via NoSpatialAwareness="true" in the render args)

[revisionfx]

Got it, I thought we were on thumbnail thread :)

@garyo - another option would be to properly name it and add a #define // for backward compatibility with Resolve property that means the same