Feat/add support for python 3.12+ reloaded #1950
Conversation
instinct-vfx
force-pushed
the
feat/add_support_for_python-3.12+_reloaded
branch
from
c455cba to
7edd950
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1950 +/- ##
=======================================
Coverage 59.28% 59.28%
=======================================
Files 126 126
Lines 17218 17218
Branches 3017 3017
=======================================
Hits 10208 10208
Misses 6325 6325
Partials 685 685 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Stephen Mackenzie <[email protected]> Signed-off-by: Thorsten Kaufmann <[email protected]>
Signed-off-by: Stephen Mackenzie <[email protected]> Signed-off-by: Thorsten Kaufmann <[email protected]>
Signed-off-by: Stephen Mackenzie <[email protected]> Signed-off-by: Thorsten Kaufmann <[email protected]>
Signed-off-by: Stephen Mackenzie <[email protected]> Signed-off-by: Thorsten Kaufmann <[email protected]>
Signed-off-by: Stephen Mackenzie <[email protected]> Signed-off-by: Thorsten Kaufmann <[email protected]>
Signed-off-by: Stephen Mackenzie <[email protected]> Signed-off-by: Thorsten Kaufmann <[email protected]>
Signed-off-by: Stephen Mackenzie <[email protected]> Signed-off-by: Thorsten Kaufmann <[email protected]>
Signed-off-by: Stephen Mackenzie <[email protected]> Signed-off-by: Thorsten Kaufmann <[email protected]>
Signed-off-by: Stephen Mackenzie <[email protected]> Signed-off-by: Thorsten Kaufmann <[email protected]>
Signed-off-by: Thorsten Kaufmann <[email protected]>
Signed-off-by: Thorsten Kaufmann <[email protected]>
Signed-off-by: Thorsten Kaufmann <[email protected]>
Signed-off-by: Thorsten Kaufmann <[email protected]>
Signed-off-by: Thorsten Kaufmann <[email protected]>
Signed-off-by: Thorsten Kaufmann <[email protected]>
Signed-off-by: Thorsten Kaufmann <[email protected]>
instinct-vfx
force-pushed
the
feat/add_support_for_python-3.12+_reloaded
branch
from
f443e2b to
1e3e1ec
Compare
| @@ -68,6 +68,7 @@ def find_files(pattern, path=None, root="rez"): | |||
| packages=find_packages('src', exclude=["build_utils", | |||
| "build_utils.*", | |||
| "tests"]), | |||
| install_requires=['setuptools'], | |||
There was a problem hiding this comment.
With this new PR, I think this is my only issue. I'll take the branch, erase setuptools on my local host, and see if I'm still able to install rez. If I can't, I do think we need to call it out on the Installation page. It's not exactly an onerous requirement, but a requirement nonetheless.
There was a problem hiding this comment.
Interesting - I erased setuptools on my local box, and it still installed... How the heck?
There was a problem hiding this comment.
For visibility:
Up to Python 3.11 when creating a virtualenv setuptools is automatically installed into the virtualenv. Starting with 3.12 this is not the case anymore. By listing setuptools as an explicit dependency installing rez with pip automatlically installs the missing setuptools.
There was a problem hiding this comment.
This is the corresponding github issue in python: python/cpython#95299
And it is also listed in the What's new in the docs: https://docs.python.org/3.12/whatsnew/3.12.html under "Important deprecations, removals or restrictions:"
There was a problem hiding this comment.
Interesting - I erased setuptools on my local box, and it still installed... How the heck?
@maxnbk install_requires means "dependencies at runtime", not "dependencies that are needed to install the project".
But now I'm curious, why do we need setuptools at runtime?
There was a problem hiding this comment.
To be brutally honest i am not entirely sure we do, but i think we do. Here is an example of a failed run:
https://github.com/instinct-vfx/rez/actions/runs/14479919556/job/40614454516#step:6:35
Note that it failed on the "install rez with rez-pip" step not on the actual install. Does that not mean we need setuptools in rez's venv for good?
| @@ -38,7 +38,8 @@ | |||
|
|
|||
| Paths should use the path separator appropriate for the operating system | |||
| (based on Python's os.path.sep). So for Linux paths, / should be used. On | |||
| Windows \ (unescaped) should be used. | |||
| Windows \\ (unescaped! A change in python 3.12 does not allow single backslashes | |||
There was a problem hiding this comment.
We could add r do the string like we usually do with regexes. THis will allow us to have a single \.
| @@ -68,6 +68,7 @@ def find_files(pattern, path=None, root="rez"): | |||
| packages=find_packages('src', exclude=["build_utils", | |||
| "build_utils.*", | |||
| "tests"]), | |||
| install_requires=['setuptools'], | |||
There was a problem hiding this comment.
Interesting - I erased setuptools on my local box, and it still installed... How the heck?
@maxnbk install_requires means "dependencies at runtime", not "dependencies that are needed to install the project".
But now I'm curious, why do we need setuptools at runtime?
Fixes #1949 builds on #1943 as many of the issues are due to outdated vendored dependencies