Skip to content

Add support for python 3.12+ and drop support for 3.7 #1950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

instinct-vfx
Copy link
Contributor

@instinct-vfx instinct-vfx commented Apr 16, 2025

Fixes #1948. Builds on #1943 as many of the issues are due to outdated vendored dependencies.

@instinct-vfx instinct-vfx requested a review from a team as a code owner April 16, 2025 11:26
@instinct-vfx instinct-vfx force-pushed the feat/add_support_for_python-3.12+_reloaded branch from c455cba to 7edd950 Compare April 16, 2025 11:28
Copy link

codecov bot commented Apr 16, 2025

Codecov Report

Attention: Patch coverage is 75.60976% with 10 lines in your changes missing coverage. Please review.

Project coverage is 59.93%. Comparing base (4708523) to head (a693974).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
src/rez/utils/pip.py 84.84% 2 Missing and 3 partials ⚠️
src/rez/utils/py_dist.py 0.00% 4 Missing ⚠️
src/rez/bind/rez.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1950      +/-   ##
==========================================
- Coverage   60.02%   59.93%   -0.09%     
==========================================
  Files         163      163              
  Lines       20118    20051      -67     
  Branches     3506     3515       +9     
==========================================
- Hits        12075    12018      -57     
+ Misses       7223     7211      -12     
- Partials      820      822       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@instinct-vfx instinct-vfx force-pushed the feat/add_support_for_python-3.12+_reloaded branch from f443e2b to 1e3e1ec Compare April 16, 2025 11:52
Copy link
Member

@JeanChristopheMorinPerso JeanChristopheMorinPerso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @instinct-vfx, I left some comments.

@maxnbk maxnbk added this to the Next milestone May 15, 2025
@maxnbk maxnbk force-pushed the feat/add_support_for_python-3.12+_reloaded branch from 1e3e1ec to 5bf9772 Compare May 15, 2025 16:16
maxnbk and others added 4 commits May 20, 2025 10:26
…es to importlib.metadata

Signed-off-by: Stephen Mackenzie <[email protected]>
Signed-off-by: Jean-Christophe Morin <[email protected]>
Signed-off-by: Jean-Christophe Morin <[email protected]>
@JeanChristopheMorinPerso
Copy link
Member

Tests are now passing. We should still try to install stuff with rez-pip, just in case. Our test suite doesn't have any tests for that.

@JeanChristopheMorinPerso
Copy link
Member

JeanChristopheMorinPerso commented Jun 21, 2025

Also, this PR technically drops support for Python 3.7 since we use importlib.metadata.

@JeanChristopheMorinPerso JeanChristopheMorinPerso changed the title Feat/add support for python 3.12+ reloaded Add support for python 3.12+ and drop support for 3.7 Jun 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for python 3.12 and python 3.13
3 participants