-
Notifications
You must be signed in to change notification settings - Fork 343
Feat/add support for python 3.12+ reloaded #1950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
instinct-vfx
wants to merge
16
commits into
AcademySoftwareFoundation:main
Choose a base branch
from
instinct-vfx:feat/add_support_for_python-3.12+_reloaded
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
5394e9a
chore: update vendor readme entry for yaml per previous py2 removal
maxnbk 06a37cd
feat: update vendored module six: 1.12.0->1.17.0
maxnbk 12b79bf
feat: update vendored module yaml: 5.1->6.0.1
maxnbk 4730869
feat: update vendored module progress: 1.5->1.6
maxnbk 6691e04
feat: update vendored module distro: 1.5.0->1.9.0
maxnbk 61a61cf
feat: update vendored module colorama: 0.4.1->0.4.6
maxnbk f5da73f
feat: update vendored module atomicwrites: 1.2.1->1.4.1
maxnbk d0aa6b6
feat: remove vendored module attr: unused
maxnbk 20aa5ce
feat: update vendored module distlib: 0.2.9.post0->0.3.9
maxnbk 3f3bb99
Change plugin_managers.py from find_module to find_spec
instinct-vfx a1466dc
Change seftest.py from find_module to find_spec
instinct-vfx 4aff12c
Add setuptools to install_requires in setup.py
instinct-vfx bd3a762
Update docstring in rezconfig.py to escape backslash
instinct-vfx aeb31c9
Add python 3.12 and 3.13 to install and test workflows
instinct-vfx 40b7824
Add 3.12 and 3.13 to installation docs
instinct-vfx 1e3e1ec
Add 3.12 to classifiers and limit supported python versions to <3.14
instinct-vfx File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -38,7 +38,8 @@ | |
|
||
Paths should use the path separator appropriate for the operating system | ||
(based on Python's os.path.sep). So for Linux paths, / should be used. On | ||
Windows \ (unescaped) should be used. | ||
Windows \\ (unescaped! A change in python 3.12 does not allow single backslashes | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We could add |
||
in docstrings. Sorry.) should be used. | ||
|
||
Note: The comments in this file are extracted and turned into documentation. Pay | ||
attention to the comment formatting and follow the existing style closely. | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With this new PR, I think this is my only issue. I'll take the branch, erase setuptools on my local host, and see if I'm still able to install rez. If I can't, I do think we need to call it out on the Installation page. It's not exactly an onerous requirement, but a requirement nonetheless.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting - I erased setuptools on my local box, and it still installed... How the heck?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For visibility:
Up to Python 3.11 when creating a virtualenv setuptools is automatically installed into the virtualenv. Starting with 3.12 this is not the case anymore. By listing setuptools as an explicit dependency installing rez with pip automatlically installs the missing setuptools.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the corresponding github issue in python: python/cpython#95299
And it is also listed in the What's new in the docs: https://docs.python.org/3.12/whatsnew/3.12.html under "Important deprecations, removals or restrictions:"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@maxnbk
install_requires
means "dependencies at runtime", not "dependencies that are needed to install the project".But now I'm curious, why do we need setuptools at runtime?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be honest i am not entirely sure we do, but i think we do. Here is an example of a failed run:
https://github.com/instinct-vfx/rez/actions/runs/14479919556/job/40614454516#step:6:35
Note that it failed on the "install rez with rez-pip" step not on the actual install. Does that not mean we need setuptools in rez's venv for good?