Skip to content

Conversation

@i-am-sijia
Copy link
Contributor

@i-am-sijia i-am-sijia commented Jul 17, 2025

@yueshuaing This PR implements example model configs developed as part of the ActivitySim Phase 9 work. The code changes that pair with this PR is in ActivitySim/activitysim#935

  • Added config files for the telecommute_status model
  • Tentatively applied telecommute_status model before cdap (Note: This is different from the final explicit telecommute model design that was developed in subsequent Phase 9B telecommute design efforts.)
    • [x] Made mandatory pattern unavailable for worker who is telecommuting on simulation day in cdap config Update: The result of telecommute_status model is not used in any downstream models.
  • Split telecommute frequency category 2_3_days_week into two categories, 2_days_week and 3_days_week
  • Replaced expressions that use telecommute_fredequency == 2_3_days_week with telecommute_fredequency == 2_days_week | telecommute_fredequency == 3_days_week in downstream model UECs

@i-am-sijia
Copy link
Contributor Author

The test is failing when validating the result against the target pipeline because we split the telecommute frequency category 2_3_days_week into two categories, 2_days_week and 3_days_week, as requested. As a result, half of the person records that previously had 2_3_days_week now have 2_days_week, and the other half have 3_days_week. I can update the target pipeline if that's ok. @jpn--

@i-am-sijia
Copy link
Contributor Author

@jpn--, this PR is ready to be merged. Additionally, I fixed the CI workflow - it was testing against the latest release instead of the 'main' branch of ActivitySim.

@jpn-- jpn-- merged commit 788a4de into ActivitySim:main Sep 26, 2025
1 check passed
@i-am-sijia i-am-sijia deleted the explicit_telecommute branch October 1, 2025 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants