-
Notifications
You must be signed in to change notification settings - Fork 8
ABM3 v15.3.1 Production Model Specifications
#37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@bhargavasana I've brought in all the updates from So far, the non-sharrow test runs successfully and the sharrow test is failing. I have made some fixes in the configs for the sharrow run and it’s now failing in trip destination (close to the end!). Please see the log attached. Should I leave this to you @jpn-- at this point to make it sharrow compatible? |
bhargavasana
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think I have anything major at this point. I will have my staff compare outputs in the next few weeks.
|
The changes in here are reviewed and OK. I opened a subordinate PR here: wsp-sag#2 to address the remaining issues. Rather than approve and merge this PR that is incomplete (and have a non-complete "main" branch) we can hopefully make one merge that gets this example up to speed and fully operational. |
This PR supersedes PR #34 and brings in model specifications from SANDAG's ABM3 production model, version
v15.3.1.The model specification changes have been manually reviewed to ensure they do not overwrite any existing Sharrow-related modifications implemented in this repository that are not present in SANDAG's production model
v15.3.1.This PR also includes a script
diff_production_configs.pywith instructions in the ReadMe.md that users can run in command line, to auto diff any versions of the ABM3 production model and the example model. Right now it will show many differences between the production model and the example model because the production model does not include Sharrow changes. If and when we get to the point where the two models are the same, this script will help easily identify new developments in the production model.