Skip to content

Pr-1 #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
CheezItMan wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Pr-1 #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions calculate_average.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@

Copy link
Copy Markdown

@bonara bonara Aug 15, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove the empty space

const calculateAverage = function calculateAverage(grades) {
Copy link
Copy Markdown

@laneia laneia Aug 15, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider refactoring into an arrow function


Copy link
Copy Markdown

@jillirami jillirami Aug 15, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (grades == null || grades == undefined) {
return "No Grades Provided";
}

let total = 0;
for (let i = 0; i < grades.length; i++) {
Copy link
Copy Markdown

@bonara bonara Aug 15, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

forEach loop might be better for an array

Copy link
Copy Markdown

@norrise120 norrise120 Aug 15, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens if grades is null? Does a statement need to be added for this edge case?

Copy link
Copy Markdown

@sjscotton sjscotton Aug 15, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe consider using a for of loop:
for (grade of grades) {
}

total += grades[i];
}

let avg = total / grades.length;
Copy link
Copy Markdown

@norrise120 norrise120 Aug 15, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What should be returned if there are no grades? I think you would get undefined here if grades is an empty array.

Copy link
Copy Markdown

@sjscotton sjscotton Aug 15, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
let avg = total / grades.length;
const avg = total / grades.length;


return avg;
};
Copy link
Copy Markdown

@bonara bonara Aug 15, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Semicolon can be removed here.


export default calculateAverage;