fix #228496 www.hepsiburada.com ad product cards#229131
fix #228496 www.hepsiburada.com ad product cards#229131
Conversation
The existing rule for the `^=sf-smart-banner` class name wasn't applied. The optimized ruleset removes this rule, so I merged it into one with the `!+ NOT_OPTIMIZED` flag. leaved a related comment: #228496 (comment)
| checkout.hepsiburada.com##div[class^="basket_container_"] div[class^="carousel_container_"] | ||
| checkout.hepsiburada.com##div[class^="basket_container_"] div[class^="reco_"] | ||
| hepsiburada.com##.Advertisement | ||
| hepsiburada.com##.hepsiads-voltran-body | ||
| hepsiburada.com##.slick-slide:has(> div:only-child > div[class] > a[href^="https://adservice"]) | ||
| hepsiburada.com###DESKTOP_MASTHEAD-googleAdvertisement | ||
| hepsiburada.com###hyd-adx | ||
| hepsiburada.com##div[class^="sf-Recommendation-"] > div[class^="sf-Recommendation-"]:has(> div[class^="sf-reco-"] > a[href^="https://adservice.hepsiburada.com/"]) | ||
| hepsiburada.com##div[data-test-id="sponsored-products"] | ||
| hepsiburada.com##div[data-test-id="sponsored-products"] | ||
| hepsiburada.com##div[id^="Advertisement_"] | ||
| hepsiburada.com##iframe[src=""] | ||
| hepsiburada.com##li:has(article[class^="productCard-module_article"] > div[class^="productCard-module_productCardRoot"] > a[href^="https://adservice.hepsiburada.com/"]) |
There was a problem hiding this comment.
As I see, some of these rules are not applied. Please check if they are obsolete, so you can remove them.
There was a problem hiding this comment.
Ok, I will check the valid rules and move the duplicate items to the !+ NOT_OPTIMIZED flag.
Because the duplicate rules show they aren't applied like the ^=sf-smart-banner rule.
There was a problem hiding this comment.
In case of optimization you only need to add the mentioned hint.
Btw, please also check where are the rules applied. For instance, I see this div[data-test-id="sponsored-products"] element only on smartphone. You can move it to AdGuard Mobile Ads filter.
There was a problem hiding this comment.
I see this div[data-test-id="sponsored-products"] element only on smartphone. You can move it to AdGuard Mobile Ads filter.
Okay, I will keep it in mind.
The duplicate rule doesn't seem to be applied like the `^=sf-smart-banner` rule during filters optimization.
This rule part `div[class^="sf-Recommendation-"] > div[class^="sf-Recommendation-"]:has(> div[class^="sf-reco-"])` specifically targets only the section heading.
mu-hun
force-pushed
the
fix-#228496-www.hepsiburada.com
branch
from
1260404 to
592a473
Compare
2 participants
Prerequisites
To avoid invalid pull requests, please check and confirm following terms
What problem does the pull request fix?
If the problem does not fall under any category that is listed here, please write a comment below in corresponding section
What issue is being fixed?
Please check the #228496 (comment) comment first.
The existing rule for the
^=sf-smart-bannerclass name wasn't applied on Android.I discovered that the same rule was duplicated 3 times.
AnnoyancesFilter/MobileApp/sections/mobile-app_specific.txt#L338, L4483, L4615This is because the mobile version uses an optimized ruleset that includes only active filters and removes the rest.
So, I merged into one with the
!+ NOT_OPTIMIZEDflag.Terms