-
Notifications
You must be signed in to change notification settings - Fork 787
fix #228496 www.hepsiburada.com ad product cards #229131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+14
−14
Merged
Changes from 4 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
e9fbba6
Fix #228496 www.hepsiburada.com ad product cards
mu-hun 3819a03
Merge duplicated rule with `!+ NOT_OPTIMIZED` flag.
mu-hun c0904af
Group the same site rules into the same lines, ordered by ASC
mu-hun 62405ea
Remove the classname from the `li` element
mu-hun 2b4246a
Move the duplicate rule to the `!+ NOT_OPTIMIZED` flag.
mu-hun 0f03284
`#hyd-adx` ad-leftover can be seen in Chrome MV3
mu-hun fcbe7a4
Remove the inactive rule
mu-hun 592a473
Narrow the ad hyperlink
mu-hun File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I see, some of these rules are not applied. Please check if they are obsolete, so you can remove them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are also duplicates.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I will check the valid rules and move the duplicate items to the
!+ NOT_OPTIMIZEDflag.Because the duplicate rules show they aren't applied like the
^=sf-smart-bannerrule.Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In case of optimization you only need to add the mentioned hint.
Btw, please also check where are the rules applied. For instance, I see this
div[data-test-id="sponsored-products"]element only on smartphone. You can move it to AdGuard Mobile Ads filter.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, I will keep it in mind.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where do you need these rules?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The last-line rule was reported in this issue. The added commit is e9fbba6
The below rule targets a row-section ad item on the product page.
You can validate it using the
.slick-slide:has(> div:only-child > div[class] > a)part of this selector.Here is the example product page
The rest of the rules are intended to remain because they might be shown in the future:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will check whether the
.hepsiads-voltran-bodyrule is needed.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both rules are required. Please review the investigation results below and approve them.
The
.hepsiads-voltran-bodyrule is necessary for both desktop and mobile. It was added in commit www.hepsiburada.com #219101.Screenshot (Disabled TurkishFilter state)
The
#DESKTOP_MASTHEAD-googleAdvertisementrule added at hepsiburada.com #132406 (comment) still appears on desktop.Screenshot (Enabled TurkishFilter)
By the way, I discovered these initial rule commits using
git log --oneline -S <rule> - <file path>.I will use this method to continue searching when a certain rule is added and where it appears, not by guessing or spending more time.