Add TECHNICAL_CANCEL event

[gcatanese]

Add missing event and order constants alphabetically (simplify maintenance).

Fix #1481

[gemini-code-assist]

Hello @gcatanese, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Summary of Changes

This pull request addresses issue #1481 by adding the missing TECHNICAL_CANCEL event code to the NotificationRequestItem.java file. Additionally, the order of the event code constants has been alphabetized to improve maintainability.

Highlights

• New Event Code: The TECHNICAL_CANCEL event code has been added to the NotificationRequestItem class.
• Code Reorganization: The event code constants within NotificationRequestItem.java have been reordered alphabetically.

Changelog

• src/main/java/com/adyen/model/notification/NotificationRequestItem.java
  • Added public static final String EVENT_CODE_TECHNICAL_CANCEL = "TECHNICAL_CANCEL";
  • Reordered event code constants alphabetically for easier maintenance.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

---

A constant missed,
Now found, the list complete,
Code's order restored.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request successfully adds the TECHNICAL_CANCEL event code to the NotificationRequestItem class and reorders the standard event codes alphabetically. Adding the new event code is necessary to support the corresponding webhook notifications, and the alphabetical sorting is a good practice that improves the maintainability and readability of the constant list. Well done on these changes!

Summary of Findings

• Missing unit test for new event code: A unit test for the newly added EVENT_CODE_TECHNICAL_CANCEL in WebhookTest.java would improve test coverage and help prevent future regressions related to handling this specific notification event.

Merge Readiness

The code changes are well-structured and achieve the stated objective. The alphabetical sorting is a good improvement for maintainability. However, I've identified a medium severity issue regarding the lack of a unit test for the new TECHNICAL_CANCEL event code. It is recommended to add this test to ensure the robustness of the library's webhook handling. Therefore, I recommend addressing this issue before merging. Please note that I am unable to directly approve this pull request; other reviewers should review and approve this code before merging.

[gemini-code-assist]

It's great that the TECHNICAL_CANCEL event code has been added. To ensure the library correctly handles this new event type and to prevent regressions in the future, could we add a corresponding unit test in WebhookTest.java? Similar tests exist for other event codes like AUTHORISATION, CAPTURE, REFUND, etc., which parse a mock JSON payload and assert that the eventCode is correctly identified.