Skip to content

Add TECHNICAL_CANCEL event #1482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 13, 2025
+11 −8
Merged

Add TECHNICAL_CANCEL event #1482

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 11 additions & 8 deletions src/main/java/com/adyen/model/notification/NotificationRequestItem.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,26 +33,29 @@
* NotificationRequestItem model class
*/
public class NotificationRequestItem {
public static final String EVENT_CODE_AUTHORISATION = "AUTHORISATION";

//Standard Event codes
public static final String EVENT_CODE_AUTHORISATION = "AUTHORISATION";
public static final String EVENT_CODE_AUTHORISATION_ADJUSTMENT = "AUTHORISATION_ADJUSTMENT";
public static final String EVENT_CODE_CANCELLATION = "CANCELLATION";
public static final String EVENT_CODE_REFUND = "REFUND";
public static final String EVENT_CODE_CANCEL_OR_REFUND = "CANCEL_OR_REFUND";
public static final String EVENT_CODE_CANCELLATION = "CANCELLATION";
public static final String EVENT_CODE_CAPTURE = "CAPTURE";
public static final String EVENT_CODE_CAPTURE_FAILED = "CAPTURE_FAILED";
public static final String EVENT_CODE_REFUND_FAILED = "REFUND_FAILED";
public static final String EVENT_CODE_REFUND_WITH_DATA = "REFUND_WITH_DATA";
public static final String EVENT_CODE_REFUNDED_REVERSED = "REFUNDED_REVERSED";
public static final String EVENT_CODE_DONATION = "DONATION";
public static final String EVENT_CODE_EXPIRE = "EXPIRE";
public static final String EVENT_CODE_HANDLED_EXTERNALLY = "HANDLED_EXTERNALLY";
public static final String EVENT_CODE_ORDER_OPENED = "ORDER_OPENED";
public static final String EVENT_CODE_ORDER_CLOSED = "ORDER_CLOSED";
public static final String EVENT_CODE_ORDER_OPENED = "ORDER_OPENED";
public static final String EVENT_CODE_PENDING = "PENDING";
public static final String EVENT_CODE_PROCESS_RETRY = "PROCESS_RETRY";
public static final String EVENT_CODE_REFUND = "REFUND";
public static final String EVENT_CODE_REFUND_FAILED = "REFUND_FAILED";
public static final String EVENT_CODE_REFUND_WITH_DATA = "REFUND_WITH_DATA";
public static final String EVENT_CODE_REFUNDED_REVERSED = "REFUNDED_REVERSED";
public static final String EVENT_CODE_REPORT_AVAILABLE = "REPORT_AVAILABLE";
public static final String EVENT_CODE_TECHNICAL_CANCEL = "TECHNICAL_CANCEL";
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

It's great that the TECHNICAL_CANCEL event code has been added. To ensure the library correctly handles this new event type and to prevent regressions in the future, could we add a corresponding unit test in WebhookTest.java? Similar tests exist for other event codes like AUTHORISATION, CAPTURE, REFUND, etc., which parse a mock JSON payload and assert that the eventCode is correctly identified.

public static final String EVENT_CODE_VOID_PENDING_REFUND = "VOID_PENDING_REFUND";
public static final String EVENT_CODE_EXPIRE = "EXPIRE";


//Dispute Event Codes
public static final String EVENT_CODE_CHARGEBACK = "CHARGEBACK";
Expand Down