Conversation
tvdeyen
force-pushed
the
alchemy-8
branch
2 times, most recently
from
078cefb to
d905f3f
Compare
We fetch products from it in the alchemy-product-select
The version for rails 7.2 and 8.0
This is the version for Rails 7.2 and 8.0
Convinience for Ruby LSP users
This is cluttering the test logs.
tvdeyen
commented
Oct 11, 2025
Member
Author
tvdeyen
left a comment
tvdeyen
left a comment
There was a problem hiding this comment.
There are changes included that are not related to the Alchemy 8 update, but to alchemy-devise usage. Can we extract those in a separate PR?
Contributor
|
Separate PR is here: #131 |
We need `Spree.mountedAt` in the product select, and with the move to importmaps we've lost the ability to add stuff successfully to `vendor/assets/alchemy/admin/all.js`. This does the same thing, just a little bit hacky.
tvdeyen
commented
Oct 15, 2025
Member
Author
tvdeyen
left a comment
tvdeyen
left a comment
There was a problem hiding this comment.
Nice work. And thanks for fixing it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates to Alchemy 8.0. Drops 7.4 support.