Allow composable pairs for mixed ACSet transformation types - #1000
Open
sdwfrost wants to merge 1 commit into
Open
Allow composable pairs for mixed ACSet transformation types#1000sdwfrost wants to merge 1 commit into
sdwfrost wants to merge 1 commit into
Conversation
Support composable-pair construction when the two morphisms use different concrete ACSet transformation types so downstream rewriting and ABM code can compose them under Catlab 0.17.\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Under Catlab 0.17 the
ComposableHomsconstructor only accepts composable pairs of identical concrete ACSet transformation types. In practice downstream rewriting (AlgebraicRewriting.jl) and ABM (AlgebraicABMs.jl) code routinely composes morphisms where one side is a plainACSetTransformationand the other is aCSetTransformation/ specialized subtype, which currently throws even though the domains/codomains match.Changes
ComposableHoms.jl: relax the composable-pair validation so mixed concrete subtypes ofACSetTransformationcan be composed, provided the codomain of the first and the domain of the second are equal.Testing
Context
Companion to the "Restore FinCat and ACSet migration helpers used by DataMigrations" PR (#999); together they complete the Catlab 0.17 surface needed to unblock the AlgebraicJulia downstream stack.
Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com