After a Copilot comment in #2559 about duplicated DimLabels in a wave created for FFI I digged a bit deeper and noticed the following:
In AI_AmpStorageControlToRowLabel each GUI control is mapped to a row label for the AmpStorageWave and the row labels are sorted by clamp mode.
There button_DataAcq_WCAuto -> WholeCellCap is in the block for IC whereas it actually is a VC control.
I checked this through: AI_GetFunctionConstantForClampMode and then mapping the function constant to the controls through AI_MapFunctionConstantToControl.
The issue is now that for VC also setvar_DataAcq_WCC maps to WholeCellCap, thus to the same row label.
I would propose to rename the row label for button_DataAcq_WCAuto to something else unique.
Then create a new version of the AmpStorageWave in GetAmplifierParamStorageWave with the new row.
I currently do not overview if there has been some fallout through the duplication, where e.g. the wrong value from the button (usually 0) was written to the AmpStorageWave and possibly written to the LBN?
After a Copilot comment in #2559 about duplicated DimLabels in a wave created for FFI I digged a bit deeper and noticed the following:
In AI_AmpStorageControlToRowLabel each GUI control is mapped to a row label for the AmpStorageWave and the row labels are sorted by clamp mode.
There
button_DataAcq_WCAuto->WholeCellCapis in the block for IC whereas it actually is a VC control.I checked this through:
AI_GetFunctionConstantForClampModeand then mapping the function constant to the controls throughAI_MapFunctionConstantToControl.The issue is now that for VC also
setvar_DataAcq_WCCmaps toWholeCellCap, thus to the same row label.I would propose to rename the row label for
button_DataAcq_WCAutoto something else unique.Then create a new version of the AmpStorageWave in GetAmplifierParamStorageWave with the new row.
I currently do not overview if there has been some fallout through the duplication, where e.g. the wrong value from the button (usually 0) was written to the AmpStorageWave and possibly written to the LBN?