Skip to content

Conversation

@njmei
Copy link
Collaborator

@njmei njmei commented Nov 19, 2025

No description provided.

@codecov
Copy link

codecov bot commented Nov 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 52.51%. Comparing base (2f51cea) to head (ebb40ed).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #47      +/-   ##
==========================================
+ Coverage   52.47%   52.51%   +0.03%     
==========================================
  Files          58       58              
  Lines        2864     2866       +2     
  Branches      246      246              
==========================================
+ Hits         1503     1505       +2     
  Misses       1334     1334              
  Partials       27       27              
Files with missing lines Coverage Δ
...c/aibs_informatics_cdk_lib/common/aws/iam_utils.py 82.85% <100.00%> (+0.50%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.


def sqs_policy_statement(
env_base: Optional[EnvBase] = None,
actions: List[str] = SQS_FULL_ACCESS_ACTIONS,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wondering if sqs:DeleteMessage is really needed in the default use case or if this should be SQS_READ_ACTIONS by default.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I recall, sqs:DeleteMessage is necessary if you have a lambda (or something else) consuming from the SQS queue. sqs:ReceiveMessage does not delete a message from the queue.

@sheriferson sheriferson self-requested a review November 19, 2025 23:41
@njmei njmei merged commit 7db65ed into main Nov 19, 2025
6 checks passed
@njmei njmei deleted the add-sqs-policy-statement branch November 19, 2025 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants