Fix bug (and tests) in sqs_policy_statement function
#48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
njmei
force-pushed
the
add-sqs-policy-statement
branch
from
ff2a1aa to
09c8c82
Compare
njmei
changed the title
sqs_policy_statement fucntionsqs_policy_statement function
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #48 +/- ##
=======================================
Coverage 52.51% 52.51%
=======================================
Files 58 58
Lines 2866 2866
Branches 246 246
=======================================
Hits 1505 1505
Misses 1334 1334
Partials 27 27
🚀 New features to boost your workflow:
|
Per AWS documentation: https://docs.aws.amazon.com/AWSSimpleQueueService/latest/SQSDeveloperGuide/sqs-overview-of-managing-access.html#sqs-resource-and-operations The ARN format for SQS resources is: `arn:aws:sqs:region:account_id:queue_name` The existing `sqs_policy_statement` function (and tests) *wrongly* assumed that a `resource_type` needed to be provided to create the following format: `arn:partition:service:region:account-id:resource-type:resource-id` This commit fixes the function (and tests) to remove the unnecessary `resource_type` that was being added to the ARN.
njmei
force-pushed
the
add-sqs-policy-statement
branch
from
09c8c82 to
c274f5c
Compare
sheriferson
approved these changes
Nov 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per AWS documentation:
https://docs.aws.amazon.com/AWSSimpleQueueService/latest/SQSDeveloperGuide/sqs-overview-of-managing-access.html#sqs-resource-and-operations
The ARN format for SQS resources is:
arn:aws:sqs:region:account_id:queue_nameThe existing
sqs_policy_statementfunction (and tests) wrongly assumed that aresource_typeneeded to be provided to create the following format:arn:partition:service:region:account-id:resource-type:resource-idThis commit fixes the function (and tests) to remove the unnecessary
resource_typethat was being added to the ARN.