-
Notifications
You must be signed in to change notification settings - Fork 38
Move release CI from circle CI to github actions #584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
t-b
wants to merge
14
commits into
master
Choose a base branch
from
move-deploy-ci-to-github-actions
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created with hatch new --init.
The new way of packaging in python is based on pyproject.toml. This allows us to have only one file defining the package properties instead of three. We also switch to hatch instead of setuptools. And the version number is now gathered from git instead of being hardcoded in ipfx/version.txt. The new source package (sdist) has the following differences: - We don't ship the tests folder anymore. It is not usable without datafiles anyway and including them would require ~250MB of disc space. - `ipfx/version.txt` is gone as the version is now gathered from git with the build-time created `ipfx/_version.py` - No more IPFX.egg-info/MANIFEST.in/setup.cfg/setup.py but only pyproject.toml - Added missing files in docs The wheel is now different in the following regard: - It is not an universal wheel anymore as Python 2 support is already long gone - No more `*dist-info` folder as we are now packaging with hatch, the files LICENSE and AUTHORS.rst are therefore manually included - Same comment regarding `ipfx/version.txt` as in the sdist The flake8 configuration can not be included in pyproject.toml, see PyCQA/flake8#234. It will also be replaced by another linter in a future commit.
And also standardize on dashes like we do for test.
We don't use a dev branch anymore and also version.txt is gone. Mention also the switch from setuptools to hatch.
Taken from pynwb in version 2c2bc850 (Remove python 3.8 support and add python 3.13 support (#2007), 2024-12-18).
The release job depends on the test jobs so we don't have to duplicate the test run code.
Only this creates ipfx/_version.py.
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #579