Skip to content

chore: Add helpful linting rules#127

Merged
lanesawyer merged 4 commits into
AllenInstitute:mainfrom
lanesawyer:lane/linting-upgrade
Apr 28, 2025
Merged

chore: Add helpful linting rules#127
lanesawyer merged 4 commits into
AllenInstitute:mainfrom
lanesawyer:lane/linting-upgrade

Conversation

@lanesawyer

Copy link
Copy Markdown
Collaborator

What

  • Improves linting setup

How

  • Adds the noUnusedImports rule to keep imports tidy and accurate
  • Adds the useHookAtTopLevel rule to enforce the Rules of Hooks in React components
  • Ran pnpm lint to automatically fix any errors (only had import errors, no rules of hooks errors!)

PR Checklist

  • Is your PR title following our conventional commit naming recommendations?
  • Have you filled in the PR Description Template?
  • Is your branch up to date with the latest in main?
  • Do the CI checks pass successfully?
  • Have you smoke tested the example applications?
  • Did you check that the changes meet accessibility standards?
  • Have you tested the application on these browsers?
    • Chrome (Fully supported)
    • Firefox (Major bug fixes supported)
    • Safari (Major bug fixes supported)

@lanesawyer lanesawyer requested a review from a team as a code owner April 20, 2025 19:08
@lanesawyer lanesawyer enabled auto-merge (squash) April 20, 2025 19:14
@lanesawyer lanesawyer mentioned this pull request Apr 21, 2025
17 tasks

@Jarbuckle Jarbuckle left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for the upgrade!

@lanesawyer lanesawyer merged commit e8a24bf into AllenInstitute:main Apr 28, 2025
@lanesawyer lanesawyer deleted the lane/linting-upgrade branch April 29, 2025 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants