Skip to content

fix: Parse axis name to match our internal casing [134]#140

Merged
lanesawyer merged 4 commits into
AllenInstitute:mainfrom
lanesawyer:lane/134-harden-axis-names
May 2, 2025
Merged

fix: Parse axis name to match our internal casing [134]#140
lanesawyer merged 4 commits into
AllenInstitute:mainfrom
lanesawyer:lane/134-harden-axis-names

Conversation

@lanesawyer

Copy link
Copy Markdown
Collaborator

What

Fixes #134.

  • Fixes parse logic for axis name so it will always match the casing we use internally for planes
  • Added a test to ensure we don't break this in the future

How

-toLowerCase() function on zod parsing

  • Wrote a test to make sure the casing matches our CartesianPlane implementation

PR Checklist

  • Is your PR title following our conventional commit naming recommendations?
  • Have you filled in the PR Description Template?
  • Is your branch up to date with the latest in main?
  • Do the CI checks pass successfully?
  • Have you smoke tested the example applications?
  • Did you check that the changes meet accessibility standards?
  • Have you tested the application on these browsers?
    • Chrome (Fully supported)
    • x ] Firefox (Major bug fixes supported)
    • Safari (Major bug fixes supported)

@lanesawyer lanesawyer requested a review from a team as a code owner April 24, 2025 06:18
@lanesawyer lanesawyer requested review from Jarbuckle and suyli7 April 24, 2025 06:18
@lanesawyer lanesawyer enabled auto-merge (squash) April 28, 2025 18:18

@Jarbuckle Jarbuckle left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense! Approved!

@lanesawyer lanesawyer merged commit 375ed77 into AllenInstitute:main May 2, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

OME-Zarr Example viewer crashes if axis name is upper case

2 participants