Skip to content

Plane: pass throttle slew limit to motors output_motor_mask function. #29011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

IamPete1
Copy link
Member

@IamPete1 IamPete1 commented Jan 5, 2025

This is a alternate way to implement slew limiting of tilt rotor motors in forward flight ( #28960).

This passes the slew limit down to the motor mask function which applies both it and the underlying motors slew rate. Unlike #28960 this results in a per motor slew. This means the slew is included for yaw differential thrust, this is inline with what is done with the left and right throttle outputs in plane. The outputs are also slewed from there position in VTOL flight rather than having a jump.

Copy link
Contributor

@tridge tridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@IamPete1 I am concerned that may impact stability on tilt-vtols when in primarily VTOL flight. Existing tunes won't have factored in this slew limit.

@IamPete1 IamPete1 force-pushed the motor_mask_slew_limit branch from 849a93c to 6808f34 Compare April 8, 2025 20:22
@IamPete1
Copy link
Member Author

IamPete1 commented Apr 8, 2025

Rebased.

hat may impact stability on tilt-vtols when in primarily VTOL flight. Existing tunes won't have factored in this slew limit.

This will only affect forward flight when the output_motor_mask method is used. VTOL flight is unaffected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants