-
Notifications
You must be signed in to change notification settings - Fork 19k
AP_NavEKF3: Manual Lane switching #29623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
rmackay9
merged 2 commits into
ArduPilot:master
from
rishabsingh3003:ekf_disable_affinity
Apr 23, 2025
Merged
AP_NavEKF3: Manual Lane switching #29623
rmackay9
merged 2 commits into
ArduPilot:master
from
rishabsingh3003:ekf_disable_affinity
Apr 23, 2025
+107
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmackay9
reviewed
Mar 27, 2025
rmackay9
reviewed
Mar 27, 2025
11d24d7
to
f1e94f8
Compare
tridge
previously requested changes
Apr 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it should be manual-only, no health check
f1e94f8
to
322d82a
Compare
rmackay9
reviewed
Apr 22, 2025
rmackay9
reviewed
Apr 22, 2025
rmackay9
reviewed
Apr 22, 2025
rmackay9
reviewed
Apr 22, 2025
322d82a
to
1c1e53c
Compare
rmackay9
approved these changes
Apr 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While doing EKF-based tests, this is helpful.
When the EK3_OPTIONS second bit is enabled, automatic lane switching will be disabled (unless the core becomes "unhealthy", which is very extreme and we should never be flying with that). And EK3_PRIMIARY core will be enforced. This also means we can select the active core from a Lua Script mid flight.
Might also have some use cases when lane switches are happening often because of small timing difference in the core. Example, flying with a single baro on a windy day and seeing lane switches isn't uncommon.
I personally also have a usecase for this PR where I am working on another branch that allows different types of sensors to be used in different lanes, for example GPS on lane 1, Ext Nav on lane 2. For testing Ext Nav, it'll be helpful to disable lane switching.