-
Notifications
You must be signed in to change notification settings - Fork 18.5k
AP_LandingGear: stop dup retract messages, clean up code #29676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How have you tested this?
SITL.....using AUX sw, auto alt deploy/retract in FBWA, and Mode takeoff to mode autoland |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change looks good but we have there is a DroneCAN module change in here too.
@IamPete1 duh, fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
commit message needs fixing
While understanding recent landing gear changes in Plane for wiki docs, I found that the code can send multiple retract texts while already retracted and that the _have_changed variable is unnecessary..also cleaned up the deploy and retract height code a bit