Skip to content

AP_LandingGear: stop dup retract messages, clean up code #29676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Hwurzburg
Copy link
Collaborator

While understanding recent landing gear changes in Plane for wiki docs, I found that the code can send multiple retract texts while already retracted and that the _have_changed variable is unnecessary..also cleaned up the deploy and retract height code a bit

Copy link
Contributor

@peterbarker peterbarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How have you tested this?

@Hwurzburg
Copy link
Collaborator Author

How have you tested this?

SITL.....using AUX sw, auto alt deploy/retract in FBWA, and Mode takeoff to mode autoland

Copy link
Member

@IamPete1 IamPete1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good but we have there is a DroneCAN module change in here too.

@Hwurzburg
Copy link
Collaborator Author

@IamPete1 duh, fixed

Copy link
Contributor

@peterbarker peterbarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

commit message needs fixing

@Hwurzburg Hwurzburg changed the title AP_Landing: stop dup retract messages, clean up code AP_LandingGear: stop dup retract messages, clean up code Apr 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants