Plane: Fix pitch stick mixing full override #29841
Open
+7
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed a bug where, in certain cases, the pitch setpoint couldn't be fully overridden via stick mixing as intended. The issue occurred because the pitch offset applied at full stick deflection was calculated as twice the maximum pitch angle in the nudge direction, and since pitch limits are often asymmetric, this could be insufficient. For example, with the default pitch range of [-25, 20], if the commanded pitch is -25º and the user nudges it fully upwards, the maximum resulting pitch would be -25 + 20 * 2 = 15º, falling short of the intended 20º. Additionally, the non-linear stick input mapping has been replaced with a linear one, which is more suitable for pitch control.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a bug where, in certain cases, the pitch setpoint couldn't be fully overridden via stick mixing as intended. The issue occurred because the pitch offset applied at full stick deflection was calculated as twice the maximum pitch angle in the nudge direction, and since pitch limits are often asymmetric, this could be insufficient.
For example, with the default pitch range of [-25, 20], if the commanded pitch is -25º and the user nudges it fully upwards, the maximum resulting pitch would be -25 + 20 * 2 = 15º, falling short of the intended 20º.
Additionally, the non-linear stick input mapping has been replaced with a linear one, which is more suitable for pitch control.