All vehicles: Fix non fatal rc failsafe bug #29846
Conversation
ArduPlane/radio.cpp
Outdated
| @@ -402,7 +402,7 @@ bool Plane::rc_throttle_value_ok(void) const | |||
| */ | |||
| bool Plane::rc_failsafe_active(void) const | |||
| { | |||
| if (!rc_throttle_value_ok()) { | |||
| if (!rc_throttle_value_ok() || (ThrFailsafe(g.throttle_fs_enabled.get()) == ThrFailsafe::Disabled)) { | |||
There was a problem hiding this comment.
this is a bit unintuitive for someone reading the code because I think it means that the RC failsafe is active when it's actually been disabled.
There was a problem hiding this comment.
i think this is already covered in Plane::rc_throttle_value_ok() implementation?
There was a problem hiding this comment.
it is not....rc_throttle_value_ok() early returns, yes, but ALWAYS when throttle failsafe is disabled, even when failsafe flag is still set ....rc_failsafe_active will return true and never return false after RC sis restored
There was a problem hiding this comment.
@rmackay9 I think I understand...I will early return on the disable instead of letting of letting it test rc_throttle value first and oring...and removing from rc_throttle_value_ok
Hwurzburg
force-pushed
the
fix_rc_failsafe_bug
branch
from
8a4a28a to
dbc5250
Compare
Hwurzburg
force-pushed
the
fix_rc_failsafe_bug
branch
from
dbc5250 to
299d031
Compare
I discovered this while working on adding RC to Sub...easy to reproduce
Sim vehicle with defaults...happens disarmed or in the air
wont clear until reboot or resetting failsafe enable
non fatal but really annoying if you run into it...
hope its doesn't make CI uhappy