Skip to content

All vehicles: Fix non fatal rc failsafe bug #29846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 6, 2025

Conversation

Hwurzburg
Copy link
Contributor

@Hwurzburg Hwurzburg commented Apr 21, 2025

I discovered this while working on adding RC to Sub...easy to reproduce

Sim vehicle with defaults...happens disarmed or in the air

  • SIM_RC_FAIL =0 you get an RC failsafe, prearm or action
  • Disable the failsafe ie FS_THR_ENABLE or THR_FAILSAFE = 0
  • SIM_RC_FAIL =1 you enabled RC, but failsafe state is still not cleared...no GCS message...prearms if disarmed on ground
    wont clear until reboot or resetting failsafe enable

non fatal but really annoying if you run into it...
hope its doesn't make CI uhappy

Copy link
Contributor

@tridge tridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the change in plane radio.cpp doesn't look right to me

@Hwurzburg Hwurzburg force-pushed the fix_rc_failsafe_bug branch 2 times, most recently from dbc5250 to 299d031 Compare April 23, 2025 16:27
Copy link
Member

@IamPete1 IamPete1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm slightly reluctant to change anything here, its a critical part of the code.

Copy link
Contributor

@rmackay9 rmackay9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with the copter and rover changes, thanks!

@Hwurzburg Hwurzburg force-pushed the fix_rc_failsafe_bug branch 3 times, most recently from a3c4f39 to d565cb8 Compare May 1, 2025 23:03
@Hwurzburg Hwurzburg force-pushed the fix_rc_failsafe_bug branch from d565cb8 to fa03674 Compare May 3, 2025 11:16
@rmackay9
Copy link
Contributor

rmackay9 commented May 6, 2025

I'm still happy with the Copter and Rover changes

@tridge tridge merged commit bcade53 into ArduPilot:master May 6, 2025
94 checks passed
@Hwurzburg Hwurzburg deleted the fix_rc_failsafe_bug branch May 6, 2025 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants