-
Notifications
You must be signed in to change notification settings - Fork 18.5k
WP_Nav update axis, units and comments #29870
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lthall
wants to merge
5
commits into
ArduPilot:master
Choose a base branch
from
lthall:20250423_WPNav_Units_and_Comments
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+151
to
+159
Vector3p _center_neu_cm; // center of circle in cm from home | ||
float _radius_cm; // radius of circle in cm | ||
float _rate_degs; // rotation speed of circle in deg/sec. +ve for cw turn | ||
float _yaw_cd; // yaw heading (normally towards circle center) | ||
float _angle_rad; // current angular position around circle in radians (0=directly north of the center of the circle) | ||
float _angle_total_rad; // total angle travelled in radians | ||
float _angular_vel_rads; // angular velocity in radians/sec | ||
float _angular_vel_max_rads; // maximum velocity in radians/sec | ||
float _angular_accel_radss; // angular acceleration in radians/sec/sec |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
Vector3p _center_neu_cm; // center of circle in cm from home | |
float _radius_cm; // radius of circle in cm | |
float _rate_degs; // rotation speed of circle in deg/sec. +ve for cw turn | |
float _yaw_cd; // yaw heading (normally towards circle center) | |
float _angle_rad; // current angular position around circle in radians (0=directly north of the center of the circle) | |
float _angle_total_rad; // total angle travelled in radians | |
float _angular_vel_rads; // angular velocity in radians/sec | |
float _angular_vel_max_rads; // maximum velocity in radians/sec | |
float _angular_accel_radss; // angular acceleration in radians/sec/sec | |
Vector3p _center_neu_cm; // center of circle in cm from home | |
float _radius_cm; // radius of circle in cm | |
float _rate_degs; // rotation speed of circle in deg/sec. +ve for cw turn | |
float _yaw_cd; // yaw heading (normally towards circle center) | |
float _angle_rad; // current angular position around circle in radians (0=directly north of the center of the circle) | |
float _angle_total_rad; // total angle traveled in radians | |
float _angular_vel_rads; // angular velocity in radians/sec | |
float _angular_vel_max_rads; // maximum velocity in radians/sec | |
float _angular_accel_radss; // angular acceleration in radians/sec/sec |
peterbarker
reviewed
Apr 24, 2025
case SubMode::WP: | ||
case SubMode::CIRCLE_MOVE_TO_EDGE: | ||
default: | ||
return wp_nav->get_wp_bearing_to_destination(); | ||
return wp_nav->get_wp_bearing_to_destination_cdeg(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We see to have both cd
and cdeg
- should we choose one?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the continued work to update axis and units.