Skip to content

WP_Nav update axis, units and comments #29870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

lthall
Copy link
Contributor

@lthall lthall commented Apr 23, 2025

This is the continued work to update axis and units.

SCB: HACK: Removing (build/CubeOrange/modules/DroneCAN/libcanard/dsdlc_generated)
SCB: Running (./waf configure --board CubeOrange --consistent-builds --bootloader) in (.)
SCB: Running (./waf bootloader) in (.)
SCB: Running (rsync -ap build/ /tmp/tmpl7cvn4cm/out-branch-CubeOrange) in (.)
Board,blimp,bootloader,copter,heli,plane,rover,sub
CubeOrange,*,*,*,*,*,*,*

Comment on lines +151 to +159
Vector3p _center_neu_cm; // center of circle in cm from home
float _radius_cm; // radius of circle in cm
float _rate_degs; // rotation speed of circle in deg/sec. +ve for cw turn
float _yaw_cd; // yaw heading (normally towards circle center)
float _angle_rad; // current angular position around circle in radians (0=directly north of the center of the circle)
float _angle_total_rad; // total angle travelled in radians
float _angular_vel_rads; // angular velocity in radians/sec
float _angular_vel_max_rads; // maximum velocity in radians/sec
float _angular_accel_radss; // angular acceleration in radians/sec/sec
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Vector3p _center_neu_cm; // center of circle in cm from home
float _radius_cm; // radius of circle in cm
float _rate_degs; // rotation speed of circle in deg/sec. +ve for cw turn
float _yaw_cd; // yaw heading (normally towards circle center)
float _angle_rad; // current angular position around circle in radians (0=directly north of the center of the circle)
float _angle_total_rad; // total angle travelled in radians
float _angular_vel_rads; // angular velocity in radians/sec
float _angular_vel_max_rads; // maximum velocity in radians/sec
float _angular_accel_radss; // angular acceleration in radians/sec/sec
Vector3p _center_neu_cm; // center of circle in cm from home
float _radius_cm; // radius of circle in cm
float _rate_degs; // rotation speed of circle in deg/sec. +ve for cw turn
float _yaw_cd; // yaw heading (normally towards circle center)
float _angle_rad; // current angular position around circle in radians (0=directly north of the center of the circle)
float _angle_total_rad; // total angle traveled in radians
float _angular_vel_rads; // angular velocity in radians/sec
float _angular_vel_max_rads; // maximum velocity in radians/sec
float _angular_accel_radss; // angular acceleration in radians/sec/sec

case SubMode::WP:
case SubMode::CIRCLE_MOVE_TO_EDGE:
default:
return wp_nav->get_wp_bearing_to_destination();
return wp_nav->get_wp_bearing_to_destination_cdeg();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We see to have both cd and cdeg - should we choose one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants