AP_Proximity: PROXIMITY is optional, so the number of devices can be specified #29873
+18
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterbarker
reviewed
Apr 23, 2025
| @@ -28,7 +28,9 @@ | |||
|
|
|||
| #include <AP_HAL/Semaphores.h> | |||
|
|
|||
| #define PROXIMITY_MAX_INSTANCES 5 // Maximum number of proximity sensor instances available on this platform | |||
| #ifndef PROXIMITY_MAX_INSTANCES | |||
There was a problem hiding this comment.
On second thoughts, I think we really should rename this before making it something someone can reasonably put in their hwdefs:
Suggested change
| #ifndef PROXIMITY_MAX_INSTANCES | |
| #ifndef AP_PROXIMITY_MAX_INSTANCES |
What do you think, @muramura ?
There was a problem hiding this comment.
I added the prefix "AP_" at the beginning.
rishabsingh3003
approved these changes
Apr 24, 2025
muramura
force-pushed
the
AP_PROXIMITY_is_optional_so_the_number_of_devices_can_be_specified
branch
from
72a2b9d to
f08ce7a
Compare
muramura
force-pushed
the
AP_PROXIMITY_is_optional_so_the_number_of_devices_can_be_specified
branch
from
f08ce7a to
73335d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PROXIMITY devices are optional.
Recently, the number of devices increased from 4 to 5.
Therefore, the number of devices will be configurable.
AFTER
BEFORE
