HAL_ChibiOS: add support for PilotGaeaSH7V1-bdshot#32416
Conversation
8620f02 to
f3e501b
Compare
|
Hi everyone, I've fixed the linting and commit naming issues. The PR is now ready. Thank your! |
|
needs commits split...one per library...ie Tools: add... and AP_HAL_ChibiOS:addd..... |
f3e501b to
c3ad688
Compare
|
Hi, I have split the commits as requested. One for HAL_ChibiOS and one for Tools. Ready for review, thanks! |
c3ad688 to
9fe05ca
Compare
Hwurzburg
left a comment
There was a problem hiding this comment.
Preliminary review....wont even look at README until these are addressed/discussed:
- CAN connector has USB power...almost assures bench setup failure due to excessive CAN device draws for most CAN units or failure of the CAN device...should be 5V
- Your hwdef has superfluous comments...AND multiple redefintion of the outputs...luckily our CI and Waf configure actually accepts redefinition of those for some reason.... (we need to fix this hole in CI)....but remove them anyway
- You have UART4 protocol as RCIN protocol, it should be DISPLAYPORT and you cant have two protocol 23 ports at the same time
- You set the baud rates for serial ports...no need, remove
- Since you want a serial LED setup....add the SERVO13_FUNCTION 120 in a defaults.parm file and add define DEFAULT_NTF_LED_TYPES 455 in hwdef
- The GPS pad row does not have access to I2C or 4V5 convenient. I would swap UART1 and UART2 protocols in the hwdef and update the pinout images...better wiring and convenience
- You could add booting from SD card to the bootloader def
- Since you don't pin out UART3 you could replace it in SERIAL ORDER with EMPTY to avoid giving the user a SERIAL4 parm set that does nothing for him
I will review the README once the hwdef issues are resolved or discussed....clean up the hwdef of superfluous comments/lines
|
Thank you for the detailed feedback! |
|
@Hwurzburg |
8a8e12d to
3db0082
Compare
0f940c0 to
408c177
Compare
558b8f9 to
4359397
Compare
Hwurzburg
left a comment
There was a problem hiding this comment.
0ne more nit, have approved since you respond so quickly, and added devcall label
4359397 to
daca73b
Compare
daca73b to
d76e746
Compare
|
This has been included in 4.7.0-beta6. Thanks! |



Summary
Add board support for the PilotGaeaSH7V1-bdshot flight controller.
Testing (more checks increases chance of being merged)
Description
This PR adds support for the PilotGaeaSH7V1-bdshot, a high-performance STM32H743-based flight controller designed for advanced drone applications.
Key Hardware Specifications:
Test Environment & Results:
mastertag (Copter-4.6.3).*Note: Bootloader binary files are included in
Tools/bootloaders/to satisfy theAP_BOOTLOADER_FLASHING_ENABLEDrequirement for the initial build validation.