Skip to content

Sub: fix remote leak detection#32614

Merged
peterbarker merged 1 commit intoArduPilot:masterfrom
ES-Alexander:sub-fix-remote-leak-detection
Apr 19, 2026
Merged

Sub: fix remote leak detection#32614
peterbarker merged 1 commit intoArduPilot:masterfrom
ES-Alexander:sub-fix-remote-leak-detection

Conversation

@ES-Alexander
Copy link
Copy Markdown
Contributor

Summary

Fixes invalid MAVLink support for remote leak detections.

Testing (more checks increases chance of being merged)

  • Checked by a human programmer
  • Tested in SITL
    • Built successfully, but not yet tested
  • Tested on hardware
  • Logs attached
  • Logs available on request
  • Autotest included

Description

Builds on ArduPilot/mavlink#494, adding implementation support for the MAV_SYS_STATUS_SENSOR_EXTENDED, and using that for the new MAV_SYS_STATUS_SENSOR_LEAK flag, instead of the unofficial bit value used previously.

Copy link
Copy Markdown
Contributor

@peterbarker peterbarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice change.

Easy to merge once the mavlink is in place

@ES-Alexander
Copy link
Copy Markdown
Contributor Author

Rebased over master, updated the MAVLink module to its master (with the new value), and made sure it still builds.

Copy link
Copy Markdown
Contributor

@Williangalvani Williangalvani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@ES-Alexander
Copy link
Copy Markdown
Contributor Author

Noting this would be a stronger PR with an autotest, but one is already in progress in #32225.

@peterbarker
Copy link
Copy Markdown
Contributor

This PR can't be merged as it has conflicts

Copy link
Copy Markdown
Contributor

@peterbarker peterbarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conflicts need resolving

@ES-Alexander ES-Alexander force-pushed the sub-fix-remote-leak-detection branch from de0d06e to 2277bf0 Compare April 18, 2026 15:57
@ES-Alexander
Copy link
Copy Markdown
Contributor Author

Rebased and it seems the MAVLink submodule has already been updated to include the new MAV_SYS_STATUS_SENSOR_LEAK value, along with the corresponding update to GCS_Common, so I've removed those commits.

I've confirmed it still builds with those changes.

@peterbarker peterbarker merged commit 3d1df9b into ArduPilot:master Apr 19, 2026
71 checks passed
@ES-Alexander ES-Alexander deleted the sub-fix-remote-leak-detection branch April 19, 2026 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Pending

Development

Successfully merging this pull request may close these issues.

3 participants