Bootloaders: Add IDs for two upcoming boards#32699
Closed
Yuri-Sharapov wants to merge 2 commits into
Closed
Conversation
Yuri-Sharapov
force-pushed
the
new_boards_id
branch
3 times, most recently
from
2714b10 to
66af53b
Compare
Author
|
@peterbarker CI issues have been fixed. Please take another look when you have a chance |
Author
|
@peterbarker CI issues have been fixed. Please review my changes. |
Contributor
|
Hi @Yuri-Sharapov, We don't accept Merge commits though I'm afraid so it would be good to rebase on master to get rid of those |
Yuri-Sharapov
force-pushed
the
new_boards_id
branch
from
18c6ff9 to
239297b
Compare
Author
|
Hi @rmackay9 Rebased on latest master. |
Contributor
|
Hi @Yuri-Sharapov, another merge commit has crept in somehow. If you can rebase on master to get rid of that that would be good. I've marked this for the next dev call so it will get reviewed for sure. txs! |
Contributor
|
@Yuri-Sharapov please use "Update with rebase" to get rid of the merge commits - it's part of the "Update branch" interface in github |
CraigElder
changed the title
Yuri-Sharapov
force-pushed
the
new_boards_id
branch
4 times, most recently
from
781174b to
899c12c
Compare
Yuri-Sharapov
force-pushed
the
new_boards_id
branch
from
899c12c to
520d641
Compare
Yuri-Sharapov
force-pushed
the
new_boards_id
branch
from
520d641 to
dfb4673
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added board ID for CSKY_AVEGA6X and CSKY_AVEGALITER03 upcoming boards