.github: Add Python and Scripting labels to pull requests

[cclauss]

Add Python and Scripting labels to pull requests that add, delete, or modify files containing those languages.
is added to pull requests that modify .py files.
Scripting is added to pull requests that modify .lua files.

Summary

Classification & Testing (check all that apply and add your own)

• Checked by a human programmer
• Non-functional change
• No-binary change
• Infrastructure change (e.g. unit tests, helper scripts)
• Automated test(s) verify changes (e.g. unit test, autotest)
• Tested manually, description below (e.g. SITL)
• Tested on hardware
• Logs attached
• Logs available on request

Description

Lua is currently 4.8%, and Python is 12.7% of this repo, so most pull requests will not modify these files. However, some contributors will have expertise in these languages and will be interested in reviewing pull requests that modify them. This quick GitHub Action will add labels to enable the rapid isolation of pull requests that contain these minority languages.

How was this tested?

• Add a Python label to pull requests that modify .py files ardupilot_wiki#7626
• https://github.com/cclauss/labels_by_language

It is quite difficult to test pull_request_target triggered GitHub Actions on a repo that you are not a maintainer of because GitHub purposefully makes it difficult to generate pull_request_target events.

[peterbarker]

How was this tested?

[cclauss]

I ran numerous tests on my own repo. Given that it runs in a few seconds yet it takes hours of CI resources here and other unrelated tests frequently fail I did not replicate those tests on this repo.

[tpwrules]

What will this do on e.g. my fork that does not have these labels? Is it a no-operation?

(Our repo does not but that would be simple to add.)

May consider changing "Lua" to "Scripting", that label already exists.

[cclauss]

It will add a Python label even if that label has not been predefined.

Changing Lua to Scripting on line 46 would change the label.

[cclauss]

Add commented-out debugging commands for those who desire to test.

[cclauss]

Changed Lua to Scripting to use that preexsisting label.

• https://github.com/ArduPilot/ardupilot/pulls?q=label:Scripting

[cclauss]

How was this tested?

Try creating a pull request at https://github.com/cclauss/labels_by_language, adding test.lua and test.py.

It is quite difficult to test pull_request_target triggered GitHub Actions on a repo that you are not a maintainer of because GitHub purposefully makes it difficult to generate pull_request_target events.

[tpwrules]

Do you think we need to remove labels if the PRs no longer contain those types of file? I see this runs on force pushes.

[tpwrules]

I don't think this super tiny optimization is worth the chance of forgetting to update it.

[cclauss]

Removed.

[cclauss]

• Delete test.py cclauss/labels_by_language#5 I am interested in reviewing pull requests that delete Python files.

I see this runs on force pushes.

Are you saying that calling github.rest.issues.addLabels() is doing a force push?!?
I doubt this workflow does because it never uses: action/checkout.

[tpwrules]

I'm saying this new workflow will update the labels on a PR if that PR is force pushed. That is what "synchronize" means AFAIK.

But it can only ever add labels if the force push has a new type. Should it remove them too if the PR is force pushed to remove a change to a type of file? Not saying it needs to, just pointing out an observation and wondering your intention.

[cclauss]

I don't think the super-tiny optimization of dealing with forced revert is worth the chance of getting it wrong.

[tpwrules]

Looks good, let's see how it does.

[cclauss]

The default color of a new GitHub label is a drab black-and-white. See:

• https://github.com/ArduPilot/ardupilot_wiki/pulls?q=is:Apr+label:Python

Label colors can be set at:
https://github.com/ArduPilot/ardupilot/labels
https://github.com/ArduPilot/ardupilot_wiki/labels
Find (or add) the Python label and click the ... at the far right.

The Python logo color, Philadelphia (#306998), worked for me.

• https://www.schemecolor.com/python-logo-colors.php

[peterbarker]

Let's see how it goes.

[cclauss]

Let's see how it goes.

• .github: Add a missing comma to labels-by-language workflow #32748