Skip to content

Remove rst-style underlining from newly-introduced markdown, add regression check#32756

Merged
peterbarker merged 2 commits into
ArduPilot:masterfrom
peterbarker:pr-claude/no-underlines-in-markdown
Apr 15, 2026
Merged

Remove rst-style underlining from newly-introduced markdown, add regression check#32756
peterbarker merged 2 commits into
ArduPilot:masterfrom
peterbarker:pr-claude/no-underlines-in-markdown

Conversation

@peterbarker

Copy link
Copy Markdown
Contributor

Summary

Fixes regression in markdown sanity, adds a regression check

Classification & Testing (check all that apply and add your own)

  • Checked by a human programmer
  • Non-functional change
  • No-binary change
  • Infrastructure change (e.g. unit tests, helper scripts)
  • Automated test(s) verify changes (e.g. unit test, autotest)
  • Tested manually, description below (e.g. SITL)
  • Tested on hardware
  • Logs attached
  • Logs available on request

When bug is re-introduced;

Checking 2 commit(s) since master...

✓ No merge commits.
✓ No fixup! commits.
✓ All commit messages have well-formed subsystem tags.
✓ All commit subject lines within 160 characters.
✓ No unacceptable author emails.
✓ All submodule updates are isolated in their own commits.
~ markdownlint-cli2 not installed.
✗ Setext/RST underline-style headings found in markdown file(s):
         libraries/AP_HAL_ChibiOS/hwdef/PrincipIoTH7Pi/README.md:10: '============'
       Use ATX-style headings (# prefix) instead.

1 check(s) failed.

Description

Fixes new markdown to remove udnerlines (it's the only markdown file in-tree which uses them)

Makes sure they can't sneak in again!

peterbarker and others added 2 commits April 14, 2026 12:45
…headings in markdown

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@peterbarker peterbarker force-pushed the pr-claude/no-underlines-in-markdown branch from fe436f6 to 7fa8c2e Compare April 14, 2026 02:47
@Hwurzburg

Copy link
Copy Markdown
Contributor

@peterbarker does the latest change stop checking merge commits on wiki PRs? master merge commits in the wiki is a pain I would like to reject and force rebases

@peterbarker

Copy link
Copy Markdown
Contributor Author

@peterbarker does the latest change stop checking merge commits on wiki PRs? master merge commits in the wiki is a pain I would like to reject and force rebases

I answered Henry elsewhere; the short answer is no.

And I created a branch against the Wiki to add check_branch_conventions.py while I was at it :-)

@peterbarker peterbarker merged commit 021f3ad into ArduPilot:master Apr 15, 2026
51 checks passed
@peterbarker peterbarker deleted the pr-claude/no-underlines-in-markdown branch April 15, 2026 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants