Skip to content

AP_NavEKF3: do not look at takeoff for zero velocity fusion#33115

Open
andyp1per wants to merge 1 commit into
ArduPilot:masterfrom
andyp1per:pr-dr-fix
Open

AP_NavEKF3: do not look at takeoff for zero velocity fusion#33115
andyp1per wants to merge 1 commit into
ArduPilot:masterfrom
andyp1per:pr-dr-fix

Conversation

@andyp1per
Copy link
Copy Markdown
Contributor

Summary

Fixes the plane dead reckoning tests, by not considering takeoff as a potential time to not fuse.

Classification & Testing (check all that apply and add your own)

  • Checked by a human programmer
  • Non-functional change
  • No-binary change
  • Infrastructure change (e.g. unit tests, helper scripts)
  • Automated test(s) verify changes (e.g. unit test, autotest)
  • Tested manually, description below (e.g. SITL)
  • Tested on hardware
  • Logs attached
  • Logs available on request

Description

This is a simpler fix than #32986 - it fixes the dead reckoning tests in an obvious way. It does mean that zero velocity fusion occurs when armed and on the ground, but t hat was true before anyway

@andyp1per andyp1per added the BUG label May 19, 2026
@andyp1per andyp1per linked an issue May 19, 2026 that may be closed by this pull request
@tridge
Copy link
Copy Markdown
Contributor

tridge commented May 20, 2026

@andyp1per I think we merge this, but I'd like to consider if we should disable the zero vel fusion when fly-forward flag is set

@rmackay9
Copy link
Copy Markdown
Contributor

We discovered during the investigation of logs from PeterB's revert PR #33128 that plane, with no GPS, will incorrectly determine that it is not flying once its air speed drops close to zero. We had a lengthy discussion about the difficulties of determining if a fixed wing is flying or not.

@tpwrules
Copy link
Copy Markdown
Contributor

What about the similar onGroundNotFlying calculation below?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Plane: regression in non-GPS navigation

4 participants