Repository navigation
fix(security): restrict comment data URLs to raster images - #1196
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comment and preview HTML currently retains
data:text/htmllinks. Removedata:from the general URL allowlist and the anchor exception in DOMPurify. Permit inline data only on imagesrcanddata-src, with explicit PNG, JPEG, GIF, WebP, AVIF, or BMP MIME types. HTML, JavaScript, SVG, and malformed data URLs are removed; ordinary links and raster images remain supported.Lazy image URLs pass through DOMPurify to the same per-tag URL validation as normal image sources. Regression tests cover both attributes, entity/control-character variants, Markdown and raw HTML rendering, and the existing backend Markdown sanitizer used for API/email output. The backend already rejects the reported links and needs no implementation change.
Security verification: the reported link survives the old sanitizer, but Chromium 149.0.7827.55 blocked navigation when clicked with both
_selfand_blank; no script execution was observed. The fixed renderer removes the href before insertion. This confirms an overly broad URL policy, not a reproduced same-origin XSS. MDN documents opaque data origins and modern browsers' top-level navigation restrictions.Validation:
make test) passes.pnpm build:all), ESLint, Prettier, andgit diff --checkpass.Refs #1176.