Skip to content

Remove legacy V8 API support and electron-specific code #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

seanwentzel
Copy link
Member

@seanwentzel seanwentzel commented Jan 15, 2025

Remove legacy V8 API support and cleanup code

  • Remove support for older V8 versions (pre v8.4)
  • Remove Electron-specific build configuration
  • Remove Node.js v0.10.x compatibility code
  • Remove async hooks compatibility code for Node.js v8/v9
  • Remove version-specific workarounds and conditionals
  • Bump version to 5.1.0

The codebase now requires modern V8/Node.js versions and removes years of accumulated compatibility layers.

@seanwentzel seanwentzel changed the title iwp Remove legacy V8 API support and electron-specific code Jan 15, 2025
Copy link
Member Author

seanwentzel commented Jan 15, 2025

@seanwentzel seanwentzel marked this pull request as ready for review January 15, 2025 23:49
Copy link

@JackStrohm-asana JackStrohm-asana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seanwentzel seanwentzel changed the base branch from sean-clean-up-weird-arch to graphite-base/5 February 3, 2025 19:02
@seanwentzel seanwentzel changed the base branch from graphite-base/5 to master February 3, 2025 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants