Skip to content

Conversation

@mcdurdin
Copy link
Contributor

Questions

Describe your pull request

The three values rewritten in HKCU\Keyboard Layout\Toggle should be of type REG_SZ.

Expectation:

Image

I also checked the HKCU\Control Panel\Accessibility\... Flag values rewritten in the same function in the registry in a stock install of Windows, and those were also of type REG_SZ, so have patched those too. I have not checked other values in other functions.

We received reports of this causing crashes in Keyman; see keymanapp/keyman#14342. (We have now patched Keyman to work around the unexpected data type.)

… REG_SZ instead of REG_DWORD

The three values rewritten in `HKCU\Keyboard Layout\Toggle` should be of type REG_SZ:

https://github.com/Atlas-OS/Atlas/blob/0b41102f1ee9696274a177db6aa913b8481377de/src/playbook/Executables/AtlasModules/Scripts/Modules/Qol/Qol.psm1#L47-L50

Expectation:

<img width="1052" height="646" alt="Image" src="https://github.com/user-attachments/assets/7894fb5b-460f-46dd-b634-a5c23b4c432a" />

I also checked the `HKCU\Control Panel\Accessibility\...` `Flag` values rewritten in the same function in the registry in a stock install of Windows, and those were also of type REG_SZ, so have patched those too. I have not checked other values in other functions.

We received reports of this causing crashes in Keyman; see keymanapp/keyman#14342. (We have now patched Keyman to work around the unexpected data type.)
Write `HKCU\Keyboard Layout\Toggle` and `...\Accessibility` values as REG_SZ instead of REG_DWORD
@github-actions github-actions bot added the playbook Playbook related issues/PRs label Nov 15, 2025
@TheyCreeper
Copy link
Member

@RadNotRed

Copy link
Member

@RadNotRed RadNotRed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@RadNotRed RadNotRed self-requested a review November 16, 2025 22:57
@TheyCreeper TheyCreeper merged commit 8de5062 into Atlas-OS:main Nov 16, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

playbook Playbook related issues/PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants