-
Notifications
You must be signed in to change notification settings - Fork 809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Forms: Make file upload field block available in beta and refine its behavior #41586
Conversation
Refine the file upload field block to use the WordPress upload icon and follow consistent field patterns in the editor. This includes using the standard field type handling and removing the disabled state to match other fields' behavior.
Prevent the file upload dialog from opening in the editor by preventing the default click behavior.
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. 🔴 Action required: We would recommend that you add a section to the PR description to specify whether this PR includes any changes to data or privacy, like so:
Follow this PR Review Process:
Still unsure? Reach out in #jetpack-developers for guidance! |
Code Coverage SummaryCoverage changed in 1 file.
|
The PR tested as expected for me. When I have the define( 'JETPACK_BLOCKS_VARIATION', 'beta' ); the block shows up for me and when I have |
Fixes #
Proposed changes:
Other information:
Testing instructions:
Enable beta blocks by adding this to your
0-sandbox.php
:Or by using the filter:
Create or edit a post with the Jetpack Form block
Add a new field to the form
Verify that:
This PR builds upon the work done in #41582, which introduced the initial file upload field implementation. The main changes are moving the block from experimental to beta status and refining its behavior in the editor to be more consistent with WordPress patterns.